linux-kernel - Re: [PATCH] net/mlx4_en: Remove the redundant NULL check for the 'my

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <afae7a4b-e39a-4775-89e4-bd967d1fdf4e@gmail.com>
Date: Wed, 2 Apr 2025 20:36:05 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Ваторопин Андрей
 <a.vatoropin@...t.ru>, Tariq Toukan <tariqt@...dia.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "lvc-project@...uxtesting.org" <lvc-project@...uxtesting.org>
Subject: Re: [PATCH] net/mlx4_en: Remove the redundant NULL check for the
 'my_ets' object

On 01/04/2025 9:15, Ваторопин Андрей wrote:
> From: Andrey Vatoropin <a.vatoropin@...t.ru>
> 
> Static analysis shows that pointer "my_ets" cannot be NULL because it
> points to the object "struct ieee_ets".
> 
> Remove the extra NULL check. It is meaningless and harms the readability
> of the code.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Andrey Vatoropin <a.vatoropin@...t.ru>
> ---
>   drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c b/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
> index 752a72499b4f..be80da03a594 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
> @@ -290,9 +290,6 @@ static int mlx4_en_dcbnl_ieee_getets(struct net_device *dev,
>   	struct mlx4_en_priv *priv = netdev_priv(dev);
>   	struct ieee_ets *my_ets = &priv->ets;
>   
> -	if (!my_ets)
> -		return -EINVAL;
> -
>   	ets->ets_cap = IEEE_8021QAZ_MAX_TCS;
>   	ets->cbs = my_ets->cbs;
>   	memcpy(ets->tc_tx_bw, my_ets->tc_tx_bw, sizeof(ets->tc_tx_bw));

Thanks for your patch.
You can add my tag when you resend, once the submission window opens.

Reviewed-by: Tariq Toukan <tariqt@...dia.com>