linux-kernel - Re: [PATCH 1/7] lib/crc: remove unnecessary prompt for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c1cbb51-cc16-4292-ad30-482d93935d91@infradead.org>
Date: Tue, 1 Apr 2025 20:42:41 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Eric Biggers <ebiggers@...nel.org>, linux-kernel@...r.kernel.org
Cc: Ard Biesheuvel <ardb@...nel.org>, linux-crypto@...r.kernel.org,
 linux-arch@...r.kernel.org
Subject: Re: [PATCH 1/7] lib/crc: remove unnecessary prompt for CONFIG_CRC32
 and drop 'default y'

Hi 

On 4/1/25 3:15 PM, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> All modules that need CONFIG_CRC32 already select it, so there is no
> need to bother users about the option, nor to default it to y.
> 

My memory from 10-20 years ago could be foggy, but ISTR that someone made at least
CRC16 and CRC32 user-selectable in order to support out-of-tree modules...
FWIW.
But they would not need to be default y.


> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
>  arch/sh/configs/edosk7705_defconfig        | 1 -
>  arch/sh/configs/kfr2r09-romimage_defconfig | 1 -
>  arch/sh/configs/sh7724_generic_defconfig   | 1 -
>  arch/sh/configs/sh7770_generic_defconfig   | 1 -
>  lib/Kconfig                                | 8 +-------
>  5 files changed, 1 insertion(+), 11 deletions(-)
> 

-- 
~Randy