linux-kernel - Re: [PATCH -tip 1/4] x86/idle: Fix argument type for MONITOR{,X} and MWAIT{,X} instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-2ii-KgGSsMMTvB@gmail.com>
Date: Wed, 2 Apr 2025 22:48:11 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Uros Bizjak <ubizjak@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH -tip 1/4] x86/idle: Fix argument type for MONITOR{,X} and
 MWAIT{,X} instructions


* Uros Bizjak <ubizjak@...il.com> wrote:

> MONITOR and MONITORX expect 32-bit unsigned integer argument in %ecx
> and %edx registers. MWAIT and MWAITX expect 32-bit usigned int
> argument in %eax and %ecx registers.

Please always include a 0/4 cover letter as well for such series, which 
gives people a chance to reply to the whole series, instead of having 
to awkwardly pick a patch to reply to. :-)

Such as this general feedback:

I've applied this series with edits to the changelogs, note in 
particular:

 patch #1:

 - Changed verbiage from 'fix' to 'standardize to u32'. There was no 
   bug to fix, using 'long' instead of 'int' is at worst an ineffiency.

 patch #3:

 - Provided much needed historic context behind ;, \t, \n beautifiers 
   used in asm() statements. These aren't just random noise added in.

 patch #4:

 - Added in the current binutils version cutoff, to make it really 
   clear why we cannot use the mnemonic yet, and how far away we are 
   from doing so.

I've also extended the Cc: list in the commit to give people a chance 
to object, to patch #3 in particular:

  8ad521aaf743 ("x86/idle: Remove .s output beautifying delimiters from simpler asm() templates")

Thanks,

	Ingo