linux-kernel - Re: [PATCH 07/30] panel/ilitek-ili9341: Use refcounted allocation in place of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <75q6u7kgyhveuzlxujoocvqfzilaxsvh3udzeltk2itwigy2n3@f5sqxddtjxuf>
Date: Wed, 2 Apr 2025 23:09:06 +0200
From: Ondřej Jirman <megi@....cz>
To: Anusha Srivatsa <asrivats@...hat.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, 
	Jessica Zhang <quic_jesszhan@...cinc.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Icenowy Zheng <icenowy@...c.io>, 
	Jagan Teki <jagan@...rulasolutions.com>, Javier Martinez Canillas <javierm@...hat.com>, 
	Michael Trimarchi <michael@...rulasolutions.com>, Michael Walle <mwalle@...nel.org>, Jagan Teki <jagan@...eble.ai>, 
	Guido Günther <agx@...xcpu.org>, Purism Kernel Team <kernel@...i.sm>, 
	Linus Walleij <linus.walleij@...aro.org>, Jianhua Lu <lujianhua000@...il.com>, 
	Stefan Mavrodiev <stefan@...mex.com>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/30] panel/ilitek-ili9341: Use refcounted allocation in
 place of devm_kzalloc()

Hi Anusha,

On Wed, Apr 02, 2025 at 11:23:45AM -0400, Anusha Srivatsa wrote:
> Move to using the new API devm_drm_panel_alloc() to allocate the
> panel.
> 
> Signed-off-by: Anusha Srivatsa <asrivats@...hat.com>
> ---
>  drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> index ff39f5dd4097e8da0a0e16c50c5bfd45c078d91c..d87b7eefe9beedd290fb59065b389b3315c85720 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> @@ -490,9 +490,11 @@ static int ili9341_dpi_probe(struct spi_device *spi, struct gpio_desc *dc,
>  	struct ili9341 *ili;
>  	int ret;
>  
> -	ili = devm_kzalloc(dev, sizeof(struct ili9341), GFP_KERNEL);
> -	if (!ili)
> -		return -ENOMEM;
> +	ili = devm_drm_panel_alloc(dev, struct ili9341, panel,
> +				   &ili9341_dpi_funcs,
> +				   DRM_MODE_CONNECTOR_DPI);
> +	if (IS_ERR(ili))
> +		return PTR_ERR(ili);
>  
>  	ili->dbi = devm_kzalloc(dev, sizeof(struct mipi_dbi),
>  				GFP_KERNEL);

Unlike in other patches, in this one you did not remove:

https://elixir.bootlin.com/linux/v6.13.7/source/drivers/gpu/drm/panel/panel-ilitek-ili9341.c#L529

	drm_panel_init(&ili->panel, dev, &ili9341_dpi_funcs,
		       DRM_MODE_CONNECTOR_DPI);

Unintentional?

kind regards,
	o.

> -- 
> 2.48.1
>