linux-kernel - Re: [PATCH] tty: serial: samsung: Fix potential buffer overflow in clkname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9a60a75-14f1-46df-b22e-6afb768a4381@kernel.org>
Date: Wed, 2 Apr 2025 06:44:17 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: jiang.peng9@....com.cn, krzk@...nel.org
Cc: shao.mingyin@....com.cn, alim.akhtar@...sung.com, yang.yang29@....com.cn,
 xu.xin16@....com.cn, ye.xingchen@....com.cn, gregkh@...uxfoundation.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] tty: serial: samsung: Fix potential buffer overflow in
 clkname

FWIW Your e-mail client broke threading.

On 02. 04. 25, 3:33, jiang.peng9@....com.cn wrote:
>> Same comments as with other patches, not possible, IMO. Plus this patch
>> looks actually worse - commit msg is hardly readable.
>>
>> Best regards,
>> Krzysztof
> 
> Hi Krzysztof,
> Thank you for your feedback. Let me briefly re-explain the change:
> The issue:
> When building with W=1, we get a format-overflow warning because "clk_uart_baud%d" could write 15-17 bytes (14 chars + 1-3 digits) into a 15-byte buffer.

Hi,

how did you come to "1-3 digits"?

thanks,
-- 
js
suse labs