linux-kernel - Re: [PATCH 0/2] TDX attestation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5bb71fdb3f9b4a1b08a169b2d6c9c70210c6d02.camel@intel.com>
Date: Wed, 2 Apr 2025 00:20:08 +0000
From: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To: "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "pbonzini@...hat.com"
	<pbonzini@...hat.com>, "seanjc@...gle.com" <seanjc@...gle.com>,
	"binbin.wu@...ux.intel.com" <binbin.wu@...ux.intel.com>
CC: "Gao, Chao" <chao.gao@...el.com>, "mikko.ylinen@...ux.intel.com"
	<mikko.ylinen@...ux.intel.com>, "Huang, Kai" <kai.huang@...el.com>, "Li,
 Xiaoyao" <xiaoyao.li@...el.com>, "Lindgren, Tony" <tony.lindgren@...el.com>,
	"Hunter, Adrian" <adrian.hunter@...el.com>, "Chatre, Reinette"
	<reinette.chatre@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Zhao, Yan Y" <yan.y.zhao@...el.com>,
	"Yamahata, Isaku" <isaku.yamahata@...el.com>
Subject: Re: [PATCH 0/2] TDX attestation support

On Wed, 2025-04-02 at 08:15 +0800, Binbin Wu wrote:
> Opens
> =====
> Linux TDX guests don't use SetupEventNotifyInterrupt for TD attestation
> currently. If no other TDX guests use it, the support for
> SetupEventNotifyInterrupt could be dropped. But it would require an opt-in
> if the support is added later.

I think we shouldn't be afraid of opt-ins. We will need one sooner or later.
Better to not add the second exit with no users.

> 
> In this patch series, KVM does sanity checks for the TDVMCALLs so that
> different userspace VMMs can save the code for sanity checks. But it could
> be dropped if it's preferred to keep KVM code simpler and let the userspace
> VMMs take the responsibility.

I say we push it to userspace to keep KVM as small as possible.