linux-kernel - RE: [PATCH v14 4/6] firmware: imx: add driver for NXP EdgeLock Enclave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <AM9PR04MB8604436079A508D7BEC853F095AF2@AM9PR04MB8604.eurprd04.prod.outlook.com>
Date: Wed, 2 Apr 2025 06:15:02 +0000
From: Pankaj Gupta <pankaj.gupta@....com>
To: Frank Li <frank.li@....com>
CC: Jonathan Corbet <corbet@....net>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Shawn Guo
	<shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix
 Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v14 4/6] firmware: imx: add driver for NXP EdgeLock
 Enclave

>> diff --git a/drivers/firmware/imx/se_ctrl.c
...
>> +		return -EINVAL;
>> +
>> +	attr->family = "Freescale i.MX";
>> +
>> +	attr->serial_number = devm_kasprintf(priv->dev,
>> +					     GFP_KERNEL, "%016llX",
>> +
GET_SERIAL_NUM_FROM_UID(s_info->d_info.uid,
>> +
MAX_UID_SIZE >> 2));

> run checkpatch.pl --strict
Already ran the checkpatch, before sending the V14 patches.
It is the false positive, as there is no possible side-effect here.

>> +
>> +	sdev = soc_device_register(attr);
>> +	if (IS_ERR(sdev))
>> +		return PTR_ERR(sdev);
>> +
>> +	return 0;
>> +}

Download attachment "smime.p7s" of type "application/pkcs7-signature" (11094 bytes)