linux-kernel - Re: [PATCH v3 2/2] clocksource/drivers/nxp-timer: Add the System Timer Module for the s32gx platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250402-ginger-hare-of-action-dc3fff@krzk-bin>
Date: Wed, 2 Apr 2025 09:05:39 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: tglx@...utronix.de, linux-kernel@...r.kernel.org, 
	thomas.fossati@...aro.org, Larisa.Grigore@....com, ghennadi.procopciuc@....com, S32@....com, 
	Ghennadi Procopciuc <ghennadi.procopciuc@....nxp.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, 
	"moderated list:ARM/STM32 ARCHITECTURE" <linux-stm32@...md-mailman.stormreply.com>, 
	"moderated list:ARM/STM32 ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 2/2] clocksource/drivers/nxp-timer: Add the System
 Timer Module for the s32gx platforms

On Wed, Apr 02, 2025 at 12:46:42AM +0200, Daniel Lezcano wrote:
> +
> +static const struct of_device_id nxp_stm_of_match[] = {
> +	{ .compatible = "nxp,s32g2-stm" },
> +	{ .compatible = "nxp,s32g3-stm" },

Drop, the entire point of me asking for compatibility is not to have
useless entries for the same devices.

> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, nxp_stm_of_match);
> +
> +static struct platform_driver nxp_stm_probe = {
> +	.probe	= nxp_stm_timer_probe,
> +	.driver	= {
> +		.name		= "nxp-stm",
> +		.of_match_table	= of_match_ptr(nxp_stm_of_match),

Drop of_match_ptr, you have here a warning.

> +	},
> +};
> +module_platform_driver(nxp_stm_probe);
> +
> +MODULE_DESCRIPTION("NXP System Timer Module driver");
> +MODULE_LICENSE("GPL");
> -- 
> 2.43.0
>