linux-kernel - Re: [PATCH] staging: media: Fix indentation to use tabs instead of spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf4abzcNFwo2W-=-fOr1_j51RAUPxDbGNVX9F-Soxbs3A@mail.gmail.com>
Date: Wed, 2 Apr 2025 10:11:30 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: gshahrouzi@...il.com
Cc: linux-media@...r.kernel.org, andy@...nel.org, hdegoede@...hat.com, 
	mchehab@...nel.org, sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org, 
	linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: media: Fix indentation to use tabs instead of spaces

On Wed, Apr 2, 2025 at 5:40 AM <gshahrouzi@...il.com> wrote:

Is it your first patch to the Linux kernel? See my comments below.

> >From d6a08153171ac52b438b6ddc1da50ebdd3550951 Mon Sep 17 00:00:00 2001
> From: Gabriel Shahrouzi <gshahrouzi@...il.com>
> Date: Tue, 1 Apr 2025 22:04:25 -0400
> Subject: [PATCH] staging: media: Fix indentation to use tabs instead of spaces

First of all, your patch is mangled. You want to use proper tools,
perhaps. One of which is `git format-patch ...` and another one is
`git send-email ...`

> Replace spaces with tab to comply with kernel coding style.

Change 'tab' to 'TAB'.

...

Change itself is okay, but is this the only one case in the entire
driver (which is something like 100k LoCs long)? Even though, and
while for the training purposes this is fine, you can also think about
checking the common style of other functions, which may be shifted
with TABs, but still having not enough spaces or so.

-- 
With Best Regards,
Andy Shevchenko