linux-kernel - Re: [PATCH v1 1/1] usbnet:fix NPE during rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025040228-mobile-busybody-e5c4@gregkh>
Date: Wed, 2 Apr 2025 08:11:07 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Ying Lu <luying526@...il.com>
Cc: oneukum@...e.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, luying1 <luying1@...omi.com>
Subject: Re: [PATCH v1 1/1] usbnet:fix NPE during rx_complete

On Wed, Apr 02, 2025 at 08:12:06AM +0800, Ying Lu wrote:
> On Tue, Apr 1, 2025 at 9:48 PM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > On Tue, Apr 01, 2025 at 08:48:01PM +0800, Ying Lu wrote:
> > > On Tue, Apr 1, 2025 at 6:31 PM Greg KH <gregkh@...uxfoundation.org> wrote:
> > > >
> > > > On Tue, Apr 01, 2025 at 06:18:01PM +0800, Ying Lu wrote:
> > > > > From: luying1 <luying1@...omi.com>
> > > > >
> > > > > Missing usbnet_going_away Check in Critical Path.
> > > > > The usb_submit_urb function lacks a usbnet_going_away
> > > > > validation, whereas __usbnet_queue_skb includes this check.
> > > > >
> > > > > This inconsistency creates a race condition where:
> > > > > A URB request may succeed, but the corresponding SKB data
> > > > > fails to be queued.
> > > > >
> > > > > Subsequent processes:
> > > > > (e.g., rx_complete → defer_bh → __skb_unlink(skb, list))
> > > > > attempt to access skb->next, triggering a NULL pointer
> > > > > dereference (Kernel Panic).
> > > > >
> > > > > Signed-off-by: luying1 <luying1@...omi.com>
> > > >
> > > > Please use your name, not an email alias.
> > > >
> > > OK, I have updated. please check the Patch v2
> > >
> > > > Also, what commit id does this fix?  Should it be applied to stable
> > > > kernels?
> > > The commit  id is 04e906839a053f092ef53f4fb2d610983412b904
> > > (usbnet: fix cyclical race on disconnect with work queue)
> > > Should it be applied to stable kernels?  -- Yes
> >
> > Please mark the commit with that information, you seem to have not done
> > so for the v2 version :(
> Thank you for your response. Could you please confirm if I understand correctly:
> Should we include in our commit message which commit id we're fixing?

No, use the correct "Fixes:" tag format as described in the
documentation.

thanks,

greg k-h