linux-kernel - Re: [PATCH v7] ufs: core: Add WB buffer resize support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250402080757.449-1-tanghuan@vivo.com>
Date: Wed,  2 Apr 2025 16:07:57 +0800
From: Huan Tang <tanghuan@...o.com>
To: bvanassche@....org
Cc: James.Bottomley@...senPartnership.com,
	alim.akhtar@...sung.com,
	avri.altman@....com,
	beanhuo@...ron.com,
	ebiggers@...gle.com,
	keosung.park@...sung.com,
	linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org,
	linux@...ssschuh.net,
	luhongfei@...o.com,
	manivannan.sadhasivam@...aro.org,
	martin.petersen@...cle.com,
	minwoo.im@...sung.com,
	opensource.kernel@...o.com,
	peter.wang@...iatek.com,
	quic_cang@...cinc.com,
	quic_mnaresh@...cinc.com,
	quic_nguyenb@...cinc.com,
	tanghuan@...o.com,
	viro@...iv.linux.org.uk
Subject: Re: [PATCH v7] ufs: core: Add WB buffer resize support

> The description of the attribute contradicts the name of the attribute.
> Wouldn't wb_resize_enable be a better name for this attribute?
> Additionally, that name will be easier to recognize for anyone who is
> familiar with the UFS 4.1 standard.
> 
> To be consistent with other sysfs attributes, the names of the verbs
> should be changed from upper case to lower case and "Others - Reserved"
> should be left out. This comment also applies to the other attributes.
> 
> > +static const char *ufs_wb_resize_hint_to_string(enum wb_resize_hint hint)
> > +{
> > +	switch (hint) {
> > +	case WB_RESIZE_HINT_KEEP:	return "KEEP";
> > +	case WB_RESIZE_HINT_DECREASE:	return "DECREASE";
> > +	case WB_RESIZE_HINT_INCREASE:	return "INCREASE";
> > +	default:	return "UNKNOWN";
> > +	}
> > +}

> The formatting of the above switch/case statement is not compliant with
> the Linux kernel coding style.

Bart sir,

Thank you for your reply .
I have modified it according to your comments, as follows:
https://lore.kernel.org/all/20250402075710.224-1-tanghuan@vivo.com/

Thank you for your patience, please help review again.

Thanks
Huan