linux-kernel - Re: [PATCH 1/1] genirq/msi: Dynamic remove/add stroage adapter hits EEH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87cydvvu7y.ffs@tglx>
Date: Wed, 02 Apr 2025 10:33:05 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Wen Xiong <wenxiong@...ux.ibm.com>
Cc: linux-kernel@...r.kernel.org, gjoyce@...ux.ibm.com,
 linux-pci@...r.kernel.org, Bjorn Helgaas <helgaas@...nel.org>,
 linux-scsi@...r.kernel.org
Subject: Re: [PATCH 1/1] genirq/msi: Dynamic remove/add stroage adapter hits
 EEH

On Tue, Apr 01 2025 at 15:14, Wen Xiong wrote:
> On 2025-03-28 06:27, Thomas Gleixner wrote:
>
>> You are completely missing the point. This is not a problem restricted
>> to PCI/MSI interrupts.
>> 
> Thanks for all suggestions! I will investigate more and check if we can 
> fix it in device driver.
>
> Looks several device drivers in kernel use two kernel APIs to set/clean 
> IRQ_NO_BALACING status for a given irq.
>
> irq_set_status_flags(irq, IRQ_NO_BALANCING);
> irq_clear_status_flags(irq, IRQ_NO_BALANCING);
>
> With these two APIs, device driver can decide if using kernel irq 
> balance or setting irq affinity by driver itself?
>
> So we can set/clear IRQ_NO_BALANCING during reset.

That's not sufficient. You are papering over the symptom. I explained
you that affinity setting is not the only way to wreckage this.

But feel free to ignore me and apply your bandaid fix as you see fit.

Thanks,

        tglx