linux-kernel - RE: [PATCH] rtlwifi: rtl892cu: Set limit for pwdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0af1b6ed8d5c400fb41f20169d0d173a@realtek.com>
Date: Wed, 2 Apr 2025 09:02:31 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Wentao Liang <vulab@...as.ac.cn>, "kvalo@...nel.org" <kvalo@...nel.org>
CC: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH] rtlwifi: rtl892cu: Set limit for pwdb_all

Wentao Liang <vulab@...as.ac.cn> wrote:
> 
> In _rtl92c_query_rxphystatus(), the return rtl_query_rxpwrpercentage()
> need to be checked. A proper implementation can be found in
> _rtl8723be_query_rxphystatus(). Add a value check and set the limit of
> pwdb_add as 100.

Have you tested on real hardware? Or just guess this is a potential problem?
If that is a real problem, please point out what it happens in commit message.

By the way, subject should be "wifi: rtlwifi: ..."

> 
> Fixes: 666e8457fae4 ("rtlwifi: rtl8192cu: Add routine mac")
> Cc: stable@...r.kernel.org # v2.6+
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
> index a76f2dc8a977..e2145f284ec0 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
> @@ -641,6 +641,9 @@ static void _rtl92c_query_rxphystatus(struct ieee80211_hw *hw,
>                         }
>                 }
>                 pwdb_all = rtl_query_rxpwrpercentage(rx_pwr_all);
> +               if (pwdb_all > 100)
> +                       pwdb_all = 100;
> +
>                 pstats->rx_pwdb_all = pwdb_all;
>                 pstats->recvsignalpower = rx_pwr_all;
>                 if (packet_match_bssid) {
> --
> 2.42.0.windows.2