linux-kernel - Re: [PATCH] perf tests switch-tracking: Fix timestamp comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250402090516.GG115840@e132581.arm.com>
Date: Wed, 2 Apr 2025 10:05:16 +0100
From: Leo Yan <leo.yan@....com>
To: Ian Rogers <irogers@...gle.com>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>,
	James Clark <james.clark@...aro.org>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tests switch-tracking: Fix timestamp comparison

On Tue, Apr 01, 2025 at 12:54:12PM -0700, Ian Rogers wrote:
> On Tue, Apr 1, 2025 at 2:14 AM Leo Yan <leo.yan@....com> wrote:
> >
> > On Mon, Mar 31, 2025 at 01:18:31PM -0700, Ian Rogers wrote:
> >
> > [...]
> >
> > > I'm reminded of a Java check I wrote for this:
> >
> > Nice short article.
> >
> > > In clang -Wshorten-64-to-32 looks to cover this. I'll see if we can
> > > clean those warnings up a bit.
> >
> > I checked a bit and seems GCC has no this flag, but it makes sense for
> > me to enable the flag for Clang.
> >
> > > Reviewed-by: Ian Rogers <irogers@...gle.com>
> >
> > Thanks a lot, Ian.
> 
> I made a small variation to the change in:
> https://lore.kernel.org/lkml/20250401182347.3422199-10-irogers@google.com/
> to avoid a subtract and just directly compare the values.

Fine by me.  I reviewed your patch, the direct comparing LGTM.

Thanks,
Leo