linux-kernel - Re: [PATCH v2] arcnet: Add NULL check in com20020pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250402090751.GH214849@horms.kernel.org>
Date: Wed, 2 Apr 2025 10:07:51 +0100
From: Simon Horman <horms@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Henry Martin <bsdhenrymartin@...il.com>, netdev@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Michael Grzeschik <m.grzeschik@...gutronix.de>,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH v2] arcnet: Add NULL check in com20020pci_probe()

On Tue, Apr 01, 2025 at 05:37:18PM +0200, Markus Elfring wrote:
> > devm_kasprintf() return NULL if memory allocation fails. Currently,
> …
>                 call?                               failed?
> 
> 
> > Add NULL check after devm_kasprintf() to prevent this issue.
> 
> Please complete also the corresponding exception handling.
> 
> Source code example for further inspiration:
> https://elixir.bootlin.com/linux/v6.14-rc6/source/drivers/net/arcnet/com20020-pci.c#L239-L244
> 
> Thus I suggest to use another label like “e_nomem” for this purpose.

Ok, but surely the err_free_arcdev label can be reused for this purpose.