linux-kernel - Re: [PATCH v3 1/4] dt-bindings: net: Add MTIP L2 switch description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250402110900.6141cc1b@wsk>
Date: Wed, 2 Apr 2025 11:09:00 +0200
From: Lukasz Majewski <lukma@...x.de>
To: Rob Herring <robh@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, davem@...emloft.net, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Richard Cochran
 <richardcochran@...il.com>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 1/4] dt-bindings: net: Add MTIP L2 switch description

On Tue, 1 Apr 2025 18:03:46 -0500
Rob Herring <robh@...nel.org> wrote:

> On Tue, Apr 01, 2025 at 12:35:07PM +0200, Lukasz Majewski wrote:
> > Hi Rob,
> >   
> > > On Mon, Mar 31, 2025 at 12:31:13PM +0200, Lukasz Majewski wrote:  
> > > > This patch provides description of the MTIP L2 switch available
> > > > in some NXP's SOCs - e.g. imx287.
> > > > 
> > > > Signed-off-by: Lukasz Majewski <lukma@...x.de>
> > > > ---
> > > > Changes for v2:
> > > > - Rename the file to match exactly the compatible
> > > >   (nxp,imx287-mtip-switch)
> > > > 
> > > > Changes for v3:
> > > > - Remove '-' from const:'nxp,imx287-mtip-switch'
> > > > - Use '^port@[12]+$' for port patternProperties
> > > > - Drop status = "okay";
> > > > - Provide proper indentation for 'example' binding (replace 8
> > > >   spaces with 4 spaces)
> > > > - Remove smsc,disable-energy-detect; property
> > > > - Remove interrupt-parent and interrupts properties as not
> > > > required
> > > > - Remove #address-cells and #size-cells from required properties
> > > > check
> > > > - remove description from reg:
> > > > - Add $ref: ethernet-switch.yaml#
> > > > ---
> > > >  .../bindings/net/nxp,imx287-mtip-switch.yaml  | 154
> > > > ++++++++++++++++++ 1 file changed, 154 insertions(+)
> > > >  create mode 100644
> > > > Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml
> > > > 
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml
> > > > b/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml
> > > > new file mode 100644 index 000000000000..98eba3665f32 ---
> > > > /dev/null +++
> > > > b/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml
> > > > @@ -0,0 +1,154 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR
> > > > BSD-2-Clause) +%YAML 1.2
> > > > +---
> > > > +$id:
> > > > http://devicetree.org/schemas/net/nxp,imx287-mtip-switch.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# +
> > > > +title: NXP SoC Ethernet Switch Controller (L2 MoreThanIP
> > > > switch) +
> > > > +maintainers:
> > > > +  - Lukasz Majewski <lukma@...x.de>
> > > > +
> > > > +description:
> > > > +  The 2-port switch ethernet subsystem provides ethernet packet
> > > > (L2)
> > > > +  communication and can be configured as an ethernet switch. It
> > > > provides the
> > > > +  reduced media independent interface (RMII), the management
> > > > data input
> > > > +  output (MDIO) for physical layer device (PHY) management.
> > > > +
> > > > +$ref: ethernet-switch.yaml#    
> > > 
> > > This needs to be: ethernet-switch.yaml#/$defs/ethernet-ports
> > > 
> > > With that, you can drop much of the below part. More below...
> > >   
> > > > +
> > > > +properties:  
> > 
> > So it shall be after the "properties:"
> > 
> > $ref: ethernet-switch.yaml#/$defs/ethernet-ports   [*]  
> 
> It can stay where it is, just add "/$defs/ethernet-ports"
> 
> 
> > > > +  compatible:
> > > > +    const: nxp,imx287-mtip-switch
> > > > +
> > > > +  reg:
> > > > +    maxItems: 1
> > > > +
> > > > +  phy-supply:
> > > > +    description:
> > > > +      Regulator that powers Ethernet PHYs.
> > > > +
> > > > +  clocks:
> > > > +    items:
> > > > +      - description: Register accessing clock
> > > > +      - description: Bus access clock
> > > > +      - description: Output clock for external device - e.g.
> > > > PHY source clock
> > > > +      - description: IEEE1588 timer clock
> > > > +
> > > > +  clock-names:
> > > > +    items:
> > > > +      - const: ipg
> > > > +      - const: ahb
> > > > +      - const: enet_out
> > > > +      - const: ptp
> > > > +
> > > > +  interrupts:
> > > > +    items:
> > > > +      - description: Switch interrupt
> > > > +      - description: ENET0 interrupt
> > > > +      - description: ENET1 interrupt
> > > > +
> > > > +  pinctrl-names: true
> > > > +    
> > >   
> > > > +  ethernet-ports:  
> > 
> > And then this "node" can be removed as it has been referenced above
> > [*]?  
> 
> Well, you have to keep it to have 'required' in the child nodes.
> 
> > 
> > (I shall only keep the properties, which are not standard to [*] if
> > any).
> >   
> > > > +    type: object
> > > > +    additionalProperties: false
> > > > +
> > > > +    properties:
> > > > +      '#address-cells':
> > > > +        const: 1
> > > > +      '#size-cells':
> > > > +        const: 0
> > > > +
> > > > +    patternProperties:
> > > > +      '^port@[12]+$':    
> > > 
> > > Note that 'ethernet-port' is the preferred node name though
> > > 'port' is allowed.  
> > 
> > Ok. That would be the correct define:
> > 
> > ethernet-ports {
> >      mtip_port1: ethernet-port@1 {
> >                reg = <1>;
> >                label = "lan0";
> >                local-mac-address = [ 00 00 00 00 00 00 ];
> >                phy-mode = "rmii";
> >                phy-handle = <&ethphy0>;
> > 	       };
> > 
> >                mtip_port2: port@2 {  
> 
> And here...
> 
> > 		....
> > 	       };
> >   
> > >   
> > > > +        type: object
> > > > +        description: MTIP L2 switch external ports
> > > > +
> > > > +        $ref: ethernet-controller.yaml#
> > > > +        unevaluatedProperties: false
> > > > +
> > > > +        properties:
> > > > +          reg:
> > > > +            items:
> > > > +              - enum: [1, 2]
> > > > +            description: MTIP L2 switch port number
> > > > +
> > > > +          label:
> > > > +            description: Label associated with this port
> > > > +
> > > > +        required:
> > > > +          - reg
> > > > +          - label
> > > > +          - phy-mode
> > > > +          - phy-handle    
> > > 
> > > All the above under 'ethernet-ports' can be dropped though you
> > > might want to keep 'required' part.  
> > 
> > Ok, I will keep it.  
> 
> So I think you just want this:
> 
> ethernet-ports:
>   type: object
>   additionalProperties: true  # Check if you need this
> 
>   patternProperties:
>     '^ethernet-port@[12]$':
>       required:
>         - label
>         - phy-mode
>         - phy-handle
> 

I had to add:

$ref: ethernet-switch.yaml#/$defs/ethernet-ports
patternProperties:
  "^(ethernet-)?ports$":
    type: object
    additionalProperties: true

after the 
description:

to avoid issues when checking DT schema.

Simple adding 

   patternProperties:
     '^ethernet-port@[12]$':
       required:
         - label
         - phy-mode
         - phy-handle

Causes more errors.

> Rob




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@...x.de

Content of type "application/pgp-signature" skipped