linux-kernel - Re: [PATCH] rust: clean Rust 1.86.0 new `clippy::needless

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mmJTYQ+9goEaq6desJCNHNeYKrQN_DJEe67ZVM_7Wggg@mail.gmail.com>
Date: Wed, 2 Apr 2025 12:55:39 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH] rust: clean Rust 1.86.0 new `clippy::needless_continue` cases

On Wed, Apr 2, 2025 at 11:18 AM Danilo Krummrich <dakr@...nel.org> wrote:
>
> Not related to the patch itself: Don't we need to disable new lints anyways?
> Otherwise we'd get warning when compiling older kernel with newer compilers /
> linters, no?

So far we are cleaning them up as they arrive (and backporting) and
deciding if we want to keep them or not etc. My plan is to eventually
have an explicit set of the ones we really, really want to keep clean,
since at some point it will be too much to clean (if the rate of
changes on Clippy is steady), and leave the rest to something like
`W=`.

In any case, `CLIPPY=1` is opt-in and the future can always give us
issues: even when we set an explicit list, sometimes lints have added
new cases (like in this patch), so we will need cleanups from time to
time either way.

Relatedly, we discussed at FOSDEM having Clippy be potentially
unconditionally used, but that would require changes on their side
first.

Cheers,
Miguel