linux-kernel - Re: [PATCH] dt-bindings: media: i2c: imx219: Remove redundant description of data-lanes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250402110815.GM1240431@ragnatech.se>
Date: Wed, 2 Apr 2025 13:08:15 +0200
From: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Dave Stevenson <dave.stevenson@...pberrypi.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, imx@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: media: i2c: imx219: Remove redundant
 description of data-lanes

On 2025-04-02 12:29:17 +0200, Krzysztof Kozlowski wrote:
> On 02/04/2025 11:57, Niklas Söderlund wrote:
> >>
> >>> Support four-lane operation") the driver errored out if not 2 lanes
> >>> where used, and after it if not 2 or 4 lanes where used.
> >>
> >> Then... fix the driver?
> >>
> >> This property describes hardware, not driver. Why current driver
> >> implementation, e.g. 1 year ago or now, would change the hardware (so
> >> the bindings)?
> > 
> > I agree, I thought that here we have a case where the bindings predate 
> > the standardisation. The driver do not match the bindings, in fact it 
> > breaks if the imx219 specific instructions are followed. So the risk of 
> > breaking stuff is likely low. And this was an opportunity to align the 
> > imx219 with video-interfaces.yaml.
> 
> I am sorry, but what breaks exactly?
> 
> Is the device supporting two and four lanes setups? If yes, then the
> binding is correct.

I understand that is the most correct reading, this should likely have 
been posted as an RFC.

The commit message states this was an attempt to see if it was possible 
to align the imx219 binding with the standard binding. The rational 
being that the imx219 bindings where created before we had common 
bindings for this and that the driver never worked with the imx219 
version of the standard bindings so likely there would be no users of 
it. Kind of like how similar bindings where rejected for IMX708 [1].

I will drop this patch, it was only a drive-by thing as I had to spend 
time fighting this when trying to use the device.

1.  https://lore.kernel.org/linux-media/949e3330-8c3d-6106-fbf8-cab820801cfc@kernel.org/

-- 
Kind Regards,
Niklas Söderlund