linux-kernel - Re: [PATCH] ASoC: Intel: avs: Add NULL check in avs_component

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed1be43c-99e0-4afb-8f98-9c7f39611610@web.de>
Date: Wed, 2 Apr 2025 14:00:31 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Henry Martin <bsdhenrymartin@...il.com>, linux-sound@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Amadeusz Sławiński
 <amadeuszx.slawinski@...ux.intel.com>,
 Bard Liao <yung-chuan.liao@...ux.intel.com>,
 Cezary Rojewski <cezary.rojewski@...el.com>,
 Ethan Carter Edwards <ethan@...ancedwards.com>,
 Jaroslav Kysela <perex@...ex.cz>, Jerome Brunet <jbrunet@...libre.com>,
 Julia Lawall <julia.lawall@...ia.fr>,
 Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
 Mark Brown <broonie@...nel.org>,
 Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
 Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
 Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
 Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH] ASoC: Intel: avs: Add NULL check in avs_component_probe()

> devm_kasprintf() returns NULL when memory allocation fails. Currently,
…
                call?                                  failed?


> Add NULL check after devm_kasprintf() to prevent this issue.

Do you generally propose here to improve the error handling?


…
> +++ b/sound/soc/intel/avs/pcm.c
> @@ -927,7 +927,8 @@ static int avs_component_probe(struct snd_soc_component *component)
>  		else
>  			mach->tplg_filename = devm_kasprintf(adev->dev, GFP_KERNEL,
>  							     "hda-generic-tplg.bin");
> -
> +		if (!mach->tplg_filename)
> +			return -ENOMEM;

Can a blank line be desirable after such a statement?


Would another source code transformation become helpful with an additional update step?

-		if (((vendor_id >> 16) & 0xFFFF) == 0x8086)
-			mach->tplg_filename = devm_kasprintf(adev->dev, GFP_KERNEL,
-							     "hda-8086-generic-tplg.bin");
-		else
-			mach->tplg_filename = devm_kasprintf(adev->dev, GFP_KERNEL,
-							     "hda-generic-tplg.bin");
+		mach->tplg_filename = devm_kasprintf(adev->dev, GFP_KERNEL,
+						     (((vendor_id >> 16) & 0xFFFF) == 0x8086)
+						     ? "hda-8086-generic-tplg.bin"
+						     : "hda-generic-tplg.bin");


Regards,
Markus