linux-kernel - Re: [PATCH 2/3] mtd: spi-nor: macronix: Remove duplicate flash info entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8c9891d-cd30-473c-837a-8243f20379ba@linaro.org>
Date: Wed, 2 Apr 2025 13:05:07 +0100
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Cheng Ming Lin <linchengming884@...il.com>, pratyush@...nel.org,
 mwalle@...nel.org, miquel.raynal@...tlin.com, richard@....at,
 vigneshr@...com, linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: alvinzhou@...c.com.tw, leoyu@...c.com.tw,
 Cheng Ming Lin <chengminglin@...c.com.tw>
Subject: Re: [PATCH 2/3] mtd: spi-nor: macronix: Remove duplicate flash info
 entries



On 4/2/25 9:51 AM, Cheng Ming Lin wrote:
> From: Cheng Ming Lin <chengminglin@...c.com.tw>
> 
> To clean up the code and reduce duplication, this entry is removed.
> 
> Signed-off-by: Cheng Ming Lin <chengminglin@...c.com.tw>

Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org>
> ---
>  drivers/mtd/spi-nor/macronix.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> index 2acd8e28d1c4..07e0bd0b70a0 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -160,13 +160,6 @@ static const struct flash_info macronix_nor_parts[] = {
>  		/* MX25U51245G */
>  		.id = SNOR_ID(0xc2, 0x25, 0x3a),
>  		.fixups = &macronix_qpp4b_fixups,
> -	}, {
> -		.id = SNOR_ID(0xc2, 0x25, 0x3a),
> -		.name = "mx66u51235f",
> -		.size = SZ_64M,
> -		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
> -		.fixup_flags = SPI_NOR_4B_OPCODES,
> -		.fixups = &macronix_qpp4b_fixups,
>  	}, {
>  		/* MX66U1G45G */
>  		.id = SNOR_ID(0xc2, 0x25, 0x3b),