linux-kernel - Re: [PATCH v2 1/1] soc: ti: PRUSS OCP configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250402120514.qbrwz3tsxnfqskbm@kinfolk>
Date: Wed, 2 Apr 2025 07:05:14 -0500
From: Nishanth Menon <nm@...com>
To: Parvathi Pudi <parvathi@...thit.com>
CC: Kevin Hilman <khilman@...libre.com>, basharath <basharath@...thit.com>,
        ssantosh <ssantosh@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        pratheesh
	<pratheesh@...com>, Prajith Jayarajan <prajith@...com>,
        Vignesh Raghavendra
	<vigneshr@...com>,
        danishanwar <danishanwar@...com>, praneeth
	<praneeth@...com>,
        srk <srk@...com>, rogerq <rogerq@...com>, afd
	<afd@...com>,
        krishna <krishna@...thit.com>, pmohan <pmohan@...thit.com>,
        mohan <mohan@...thit.com>
Subject: Re: [PATCH v2 1/1] soc: ti: PRUSS OCP configuration

On 17:19-20250402, Parvathi Pudi wrote:
> Hi Nishanth,
>  
> >> On 18:29-20250108, Basharath Hussain Khaja wrote:
> >>> From: Roger Quadros <rogerq@...com>
> >>> 
> >>> Updates OCP master port configuration to enable memory access outside
> >>> of the PRU-ICSS subsystem.
> >>> 
> >>> This set of changes configures PRUSS_SYSCFG.STANDBY_INIT bit either
> >>> to enable or disable the OCP master ports (applicable only on SoCs
> >>> using OCP interconnect like the OMAP family).
> >>> 
> >>> Signed-off-by: Roger Quadros <rogerq@...com>
> >>> Signed-off-by: Andrew F. Davis <afd@...com>
> >>> Signed-off-by: Parvathi Pudi <parvathi@...thit.com>
> >>> Signed-off-by: Basharath Hussain Khaja <basharath@...thit.com>
> >> 
> >> On the verge of applying this patch, looking deeper, I noticed
> >> drivers/bus/ti-sysc.c managing the sysc controls. infact, I wonder if
> >> b2745d92bb015cc4454d4195c4ce6e2852db397e ("bus: ti-sysc: Add support
> >> for PRUSS SYSC type") could be merged with this?
> >> 
> >> 
> >> Could you say why drivers/bus/ti-sysc.c would'nt be the right solution?
> >> 
> >> Ccying Kevin if he has any ideas about this.
> >> 
> > 
> > Thank you for the feedback.
> > 
> > We will analyze ti-sysc and revert back with an update shortly.
> > 
> 
> We've reviewed the code and decided to bypass the SOC patch posted here.
> Instead, we have implemented the required changes in the "drivers/bus/ti-sysc.c"
> file to enable OCMC access to the PRU-ICSS and verified the Ethernet
> functionality over PRUETH on AM335x, AM437x and AM57x platforms.
> 
> This patch will be abandoned and a new patch will be posted with
> "drivers/bus/ti-sysc.c" changes shortly.

Thank you for your patience and taking in feedback.
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D