[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <223da324-4de7-4e62-b001-ea89c4768a13@ti.com>
Date: Wed, 2 Apr 2025 19:05:21 +0530
From: Devarsh Thakkar <devarsht@...com>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
CC: <sakari.ailus@...ux.intel.com>, <u.kleine-koenig@...libre.com>,
<vigneshr@...com>, <aradhya.bhatia@...ux.dev>, <s-jain1@...com>,
<r-donadkar@...com>, <vkoul@...nel.org>, <kishon@...nel.org>,
<mripard@...nel.org>, <linux-phy@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] phy: cadence: cdns-dphy: Update calibration wait
time for startup state machine
Hi Tomi,
Thanks for the review.
On 02/04/25 17:12, Tomi Valkeinen wrote:
> Hi,
>
> On 26/03/2025 17:23, Devarsh Thakkar wrote:
>> Use system characterized reset value specified in TRM [1] to program
>> calibration wait time which defines number of cycles to wait for after
>> startup state machine is in bandgap enable state.
>>
>> This fixes PLL lock timeout error faced while using RPi DSI Panel on TI's
>> AM62L and J721E SoC [2].
>>
>> [1] AM62P TRM (Section ):
>> https://www.ti.com/lit/pdf/spruj83
>>
>> [2]:
>> Link: https://gist.github.com/devarsht/89e4830e886774fcd50aa6e29cce3a79
>>
>> Cc: stable@...r.kernel.org
>> Fixes: 7a343c8bf4b5 ("phy: Add Cadence D-PHY support")
>> Signed-off-by: Devarsh Thakkar <devarsht@...com>
>> ---
>> V2: Introduced this as as separate patch
>>
>> drivers/phy/cadence/cdns-dphy.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/phy/cadence/cdns-dphy.c
>> b/drivers/phy/cadence/cdns-dphy.c
>> index c4de9e4d3e93..11fbffe5aafd 100644
>> --- a/drivers/phy/cadence/cdns-dphy.c
>> +++ b/drivers/phy/cadence/cdns-dphy.c
>> @@ -30,6 +30,7 @@
>> #define DPHY_CMN_SSM DPHY_PMA_CMN(0x20)
>> #define DPHY_CMN_SSM_EN BIT(0)
>> +#define DPHY_CMN_SSM_CAL_WAIT_TIME GENMASK(8, 1)
>> #define DPHY_CMN_TX_MODE_EN BIT(9)
>> #define DPHY_CMN_PWM DPHY_PMA_CMN(0x40)
>> @@ -405,6 +406,8 @@ static int cdns_dphy_configure(struct phy *phy,
>> union phy_configure_opts *opts)
>> reg = FIELD_PREP(DPHY_BAND_CFG_LEFT_BAND, band_ctrl) |
>> FIELD_PREP(DPHY_BAND_CFG_RIGHT_BAND, band_ctrl);
>> writel(reg, dphy->regs + DPHY_BAND_CFG);
>> + writel(FIELD_PREP(DPHY_CMN_SSM_CAL_WAIT_TIME, 0x14) |
>> DPHY_CMN_SSM_EN | DPHY_CMN_TX_MODE_EN,
>> + dphy->regs + DPHY_CMN_SSM);
>
> This sounds like a TI specific characterized value, but the function
> here is a generic one. Also, is the value same for all TI SoCs? Or is it
> per-soc?
>
No this is not TI specific value. As mentioned in commit message, 0x14
is the cadence characterized default value for calibration wait time
which they put in as reset value in the IP (if you reset the IP you will
see calibration wait time as 0x14) to be used by software for optimal
initialization.
Regards
Devarsh
Powered by blists - more mailing lists