linux-kernel - Re: [PATCH v2] lib/iov_iter: fix to increase non slab folio refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <64b5a8d5-6e58-401b-8cf4-404df0a11d07@suse.cz>
Date: Wed, 2 Apr 2025 15:45:12 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Sheng Yong <shengyong2021@...il.com>, akpm@...ux-foundation.org,
 willy@...radead.org
Cc: linux-kernel@...r.kernel.org, linux-mm@...hiver.kernel.org,
 Sheng Yong <shengyong1@...omi.com>
Subject: Re: [PATCH v2] lib/iov_iter: fix to increase non slab folio refcount

On 4/2/25 15:36, Sheng Yong wrote:
> On 4/1/25 23:22, Vlastimil Babka wrote:
>> On 4/1/25 16:47, Sheng Yong wrote:
>>> From: Sheng Yong <shengyong1@...omi.com>
> [...]
>>>
>>> Fixes: b9c0e49abfca ("mm: decline to manipulate the refcount on a slab page")
>> 
>> Sigh. That went to v6.14
>> 
>> mm-hotfixes and Cc: stable then?
> 
> Hi, Vlastimil,

Hi,

> Shall I resend this patch with Cc: tag to the stable list?

Andrew can do it when picking up the patch so no need to. Thanks.

> thanks,
> sheng
> 
>> 
>>> Signed-off-by: Sheng Yong <shengyong1@...omi.com>
>> 
>> Acked-by: Vlastimil Babka <vbabka@...e.cz>
>> 
>> Thanks.
>> 
>>> ---
>>>   lib/iov_iter.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>> ---
>>> v2:
>>>    * update commit message
>>>    * update coding style
>>>
>>> diff --git a/lib/iov_iter.c b/lib/iov_iter.c
>>> index 8c7fdb7d8c8f..bc9391e55d57 100644
>>> --- a/lib/iov_iter.c
>>> +++ b/lib/iov_iter.c
>>> @@ -1191,7 +1191,7 @@ static ssize_t __iov_iter_get_pages_alloc(struct iov_iter *i,
>>>   			return -ENOMEM;
>>>   		p = *pages;
>>>   		for (int k = 0; k < n; k++) {
>>> -			struct folio *folio = page_folio(page);
>>> +			struct folio *folio = page_folio(page + k);
>>>   			p[k] = page + k;
>>>   			if (!folio_test_slab(folio))
>>>   				folio_get(folio);
>> 
>