[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20250402020513.42628-1-bsdhenrymartin@gmail.com>
Date: Wed, 2 Apr 2025 10:05:13 +0800
From: Henry Martin <bsdhenrymartin@...il.com>
To: dave.stevenson@...pberrypi.com
Cc: mturquette@...libre.com,
sboyd@...nel.org,
florian.fainelli@...adcom.com,
bcm-kernel-feedback-list@...adcom.com,
popcornmix@...il.com,
mripard@...nel.org,
u.kleine-koenig@...libre.com,
linux-clk@...r.kernel.org,
linux-rpi-kernel@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org,
nathan@...nel.org,
Henry Martin <bsdhenrymartin@...il.com>
Subject: [PATCH v2] clk: bcm: rpi: Add NULL check in raspberrypi_clk_register()
devm_kasprintf() returns NULL when memory allocation fails. Currently,
raspberrypi_clk_register() does not check for this case, which results
in a NULL pointer dereference.
Add NULL check after devm_kasprintf() to prevent this issue.
Fixes: 93d2725affd6 ("clk: bcm: rpi: Discover the firmware clocks")
Signed-off-by: Henry Martin <bsdhenrymartin@...il.com>
Reviewed-by: Dave Stevenson <dave.stevenson@...pberrypi.com>
---
V1 -> V2: Correct the commit hash in the Fixes: tag.
drivers/clk/bcm/clk-raspberrypi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
index 0e1fe3759530..720acc10f8aa 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -286,6 +286,8 @@ static struct clk_hw *raspberrypi_clk_register(struct raspberrypi_clk *rpi,
init.name = devm_kasprintf(rpi->dev, GFP_KERNEL,
"fw-clk-%s",
rpi_firmware_clk_names[id]);
+ if (!init.name)
+ return ERR_PTR(-ENOMEM);
init.ops = &raspberrypi_firmware_clk_ops;
init.flags = CLK_GET_RATE_NOCACHE;
--
2.34.1
Powered by blists - more mailing lists