linux-kernel - Re: [PATCH V2] remoteproc: core: Clear table_sz when rproc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <v5xgigrvpy6shmgdkivmxywkacsubnsimk6vyrue4mmoyufpbk@br7lnyvtnatc>
Date: Wed, 2 Apr 2025 08:48:58 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Peng Fan <peng.fan@....nxp.com>
Cc: Mathieu Poirier <mathieu.poirier@...aro.org>, 
	Arnaud Pouliquen <arnaud.pouliquen@...com>, 
	"open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" <linux-remoteproc@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, 
	Peng Fan <peng.fan@....com>
Subject: Re: [PATCH V2] remoteproc: core: Clear table_sz when rproc_shutdown

On Wed, Apr 02, 2025 at 09:43:55AM +0800, Peng Fan wrote:
> On Tue, Apr 01, 2025 at 10:05:03AM -0600, Mathieu Poirier wrote:
> >On Tue, Apr 01, 2025 at 09:41:24AM +0800, Peng Fan wrote:
...
> >
> >The core is already checking if @loaded_table is valid in rproc_start(), why
> >can't that be used instead of adding yet another check?
> 
> Ah. I was thinking clear table_sz in rpoc_shutdown is an easy approach and
> could benifit others in case other platforms meet similar issue in future.
> 

I like the general idea of keeping things clean and avoid leaving stale
data behind.

But clearing table_sz during stop in order to hide the fact that the
future table_ptr will contain valid data that shouldn't be used, that's
just a bug waiting to show up again in the future.

Regards,
Bjorn