linux-kernel - Re: [git pull] drm for 6.15-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r02a1xge.fsf@intel.com>
Date: Wed, 02 Apr 2025 16:53:37 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Jason Gunthorpe <jgg@...dia.com>
Cc: Masahiro Yamada <masahiroy@...nel.org>, Linus Torvalds
 <torvalds@...ux-foundation.org>, Dave Airlie <airlied@...il.com>,
 dri-devel <dri-devel@...ts.freedesktop.org>, LKML
 <linux-kernel@...r.kernel.org>
Subject: Re: [git pull] drm for 6.15-rc1

On Wed, 02 Apr 2025, Jason Gunthorpe <jgg@...dia.com> wrote:
> On Wed, Apr 02, 2025 at 03:56:37PM +0300, Jani Nikula wrote:
>> On Tue, 01 Apr 2025, Jason Gunthorpe <jgg@...dia.com> wrote:
>> > On Tue, Apr 01, 2025 at 10:42:35PM +0300, Jani Nikula wrote:
>> >> On Tue, 01 Apr 2025, Jason Gunthorpe <jgg@...dia.com> wrote:
>> >> > So, I'd suggest a better way to run this is first build the kernel,
>> >> > then mine the gcc -MD output (ie stored in the .XX.cmd files) to
>> >> > generate a list of headers that are actually part of the build, then
>> >> > only test those. That eliminates all the kconfig problems. Opt out any
>> >> > special headers that really have a good reason not to be stand alone.
>> >> 
>> >> I think we'd want the drm headers pass the checks independent of configs
>> >> (apart from CONFIG_DRM). One size doesn't fit all.
>> >
>> > Why? That demand is just making it impossible to make shared
>> > infrastructure, and I don't think DRM should go off and build its own
>> > stuff just for DRM in a way that nobody else can use it.
>> >
>> > If you really, really, care then you can have your makefile codegen an
>> > "allheaders.c" that #includes drm/*.h and compile that.
>> 
>> The v2 series [1] generalizes the header checks and it's no longer in
>> any way dependent on DRM. For starters, each subsystem/driver needs to
>> decide for themselves which headers are to be checked.
>
> Yuk. The idea at the top of this email is alot better. Why don't you
> implement it?

Because quite frankly I don't have the time, and I've already spent a
disproportionate amount of the time I didn't have on hiding the turds on
the existing header test thing this week.

>> This can be expanded with more clever ways to choose the headers to
>> check. But we have to start *somewhere*.
>
> Bah, that argument only works if nobody has better ideas. There are
> meaningful technical problems with your approach, and proposed
> solutions here.

There are also meaningful social problems with the approach of making
people do a lot of stuff they didn't have time to do in the first place,
just to end up not merging any of it ever.

What I've been focusing on is to fix this stuff enough to make it work
for 6.15. If it's accepted, *maybe* I'll look at further improvements
for the next merge window. And if there's enough interest, there's a
baseline for others to build on. But right now, seems to me it could all
just be reverted in a whim, with all the time wasted.


BR,
Jani.

-- 
Jani Nikula, Intel