linux-kernel - Re: clk: davinci: Add NULL check in davinci_lpsc_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b84e7e9-4ea4-4af7-a57b-3959c5bbdd4a@lechnology.com>
Date: Wed, 2 Apr 2025 09:05:50 -0500
From: David Lechner <david@...hnology.com>
To: Markus Elfring <Markus.Elfring@....de>,
 Henry Martin <bsdhenrymartin@...il.com>, linux-clk@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>
Subject: Re: clk: davinci: Add NULL check in davinci_lpsc_clk_register()

On 4/2/25 2:48 AM, Markus Elfring wrote:

> 
> Would you like to clarify any more why the function “kzalloc” is still called here
> (instead of the variant “devm_kzalloc”)?
> https://elixir.bootlin.com/linux/v6.14-rc6/source/drivers/clk/davinci/psc.c#L242

It is a case of "if it isn't broke, don't fix it". While there is room for
some small improvements like that, it does come at a cost of time and energy
to make those improvements.

> 
> Regards,
> Markus