linux-kernel - Re: [PATCH RFC 2/2] crypto: ti: Add support for MD5 in DTHE V2 Hashing Engine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ccfcebd-db24-4186-820a-edb14d0d2caa@ti.com>
Date: Wed, 2 Apr 2025 19:51:01 +0530
From: T Pratham <t-pratham@...com>
To: Herbert Xu <herbert@...dor.apana.org.au>
CC: "David S. Miller" <davem@...emloft.net>, <linux-crypto@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Vignesh Raghavendra <vigneshr@...com>,
        Praneeth Bajjuri <praneeth@...com>,
        Kamlesh Gurudasani <kamlesh@...com>,
        Manorit Chawdhry <m-chawdhry@...com>
Subject: Re: [PATCH RFC 2/2] crypto: ti: Add support for MD5 in DTHE V2
 Hashing Engine driver


On 02/04/25 19:20, Herbert Xu wrote:
> On Tue, Feb 18, 2025 at 04:19:43PM +0530, T Pratham wrote:
>> +static int dthe_md5_cra_init(struct crypto_tfm *tfm)
> Please stop using the obsolete cra_init/cra_exit interface.
> Use the typed init_tfm/exit_tfm interface instead.
>
> Thanks,

Ok. Will update this.

Just my 2 cents: this would be more streamlined if there is some
documentation indicating the proper usage or code comments indicating
obsolete/planned to be removed APIs.

Regards
T Pratham <t-pratham@...com>