linux-kernel - Re: [PATCH] xen: Change xen-acpi-processor dom0 dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fb49337-e1df-41fe-abba-6b2104094a68@amd.com>
Date: Wed, 2 Apr 2025 10:34:33 -0400
From: Jason Andryuk <jason.andryuk@....com>
To: Jürgen Groß <jgross@...e.com>, Stefano Stabellini
	<sstabellini@...nel.org>, Oleksandr Tyshchenko
	<oleksandr_tyshchenko@...m.com>
CC: Penny Zheng <penny.zheng@....com>, Jan Beulich <jbeulich@...e.com>,
	<xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xen: Change xen-acpi-processor dom0 dependency

On 2025-04-02 10:24, Jürgen Groß wrote:
> On 31.03.25 19:29, Jason Andryuk wrote:
>> xen-acpi-processor functions under a PVH dom0 with only a
>> xen_initial_domain() runtime check.  Change the Kconfig dependency from
>> PV dom0 to generic dom0 to reflect that.
>>
>> Suggested-by: Jan Beulich <jbeulich@...e.com>
>> Signed-off-by: Jason Andryuk <jason.andryuk@....com>
>> ---
>>   drivers/xen/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
>> index f7d6f47971fd..24f485827e03 100644
>> --- a/drivers/xen/Kconfig
>> +++ b/drivers/xen/Kconfig
>> @@ -278,7 +278,7 @@ config XEN_PRIVCMD_EVENTFD
>>   config XEN_ACPI_PROCESSOR
>>       tristate "Xen ACPI processor"
>> -    depends on XEN && XEN_PV_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
>> +    depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
>>       default m
>>       help
>>         This ACPI processor uploads Power Management information to 
>> the Xen
> 
> Assuming that all needed hypercalls are fine for PVH dom0:

It's platform_op XENPF_set_processor_pminfo and XENPF_get_cpuinfo.  Xen 
doesn't check if the caller is PV or PVH.

> Reviewed-by: Juergen Gross <jgross@...e.com>

Thanks, Juergen.

-Jason