linux-kernel - Re: [PATCH v3] locking/local_lock, mm: Replace localtry_ helpers with local_trylock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250402201252.8926c547a327ce91c61fd620@linux-foundation.org>
Date: Wed, 2 Apr 2025 20:12:52 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: bpf@...r.kernel.org, linux-mm@...ck.org, torvalds@...ux-foundation.org,
 daniel@...earbox.net, andrii@...nel.org, martin.lau@...nel.org,
 peterz@...radead.org, vbabka@...e.cz, bigeasy@...utronix.de,
 rostedt@...dmis.org, shakeel.butt@...ux.dev, mhocko@...e.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] locking/local_lock, mm: Replace localtry_ helpers
 with local_trylock_t type

On Wed,  2 Apr 2025 19:55:14 -0700 Alexei Starovoitov <alexei.starovoitov@...il.com> wrote:

> Partially revert commit 0aaddfb06882 ("locking/local_lock: Introduce localtry_lock_t").
> Remove localtry_*() helpers, since localtry_lock() name might
> be misinterpreted as "try lock".
> 

So many macros grumble.

+#define local_trylock_init(lock)	__local_trylock_init(lock)
+#define local_trylock(lock)		__local_trylock(lock)
+#define local_trylock_irqsave(lock, flags)			\
+#define __local_trylock_init(lock) __local_lock_init(lock.llock)
+#define __local_lock_acquire(lock)					\
+#define __local_trylock(lock)					\
+#define __local_trylock_irqsave(lock, flags)			\
+#define __local_lock_release(lock)					\
+#define __local_unlock(lock)					\
+#define __local_unlock_irq(lock)				\
+#define __local_unlock_irqrestore(lock, flags)			\
+#define __local_lock_nested_bh(lock)				\
+#define __local_unlock_nested_bh(lock)				\
+#define __local_trylock_init(l)			__local_lock_init(l)
+#define __local_trylock(lock)					\
+#define __local_trylock_irqsave(lock, flags)			\

I expect many of these could have been implemented as static inlines.

Oh well, that's a separate project for someone sometime.