linux-kernel - Re: [PATCH] pwm: rcar: include linux/bitfield.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <oliggucdkxoowajjgszzxips77x4p4y6v4wav56r6cqzu6cdil@rghywo2xqrrm>
Date: Thu, 3 Apr 2025 16:44:37 +0200
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, linux-pwm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: rcar: include linux/bitfield.h

Hello Arnd,

On Thu, Apr 03, 2025 at 03:23:59PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The use of FIELD_MAX() breaks in some configurations because of
> a missing header:
> 
> drivers/pwm/pwm-rcar.c:114:12: error: call to undeclared function 'FIELD_MAX'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>   114 |         if (tmp > FIELD_MAX(RCAR_PWMCNT_CYC0_MASK))
>       |                   ^
> 
> Fixes: edd549f4956b ("pwm: rcar: Improve register calculation")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

I already fixed that in my pwm/for-next branch. I did exactly what you
did and squashed that in the offending commit.

Thanks for caring
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)