linux-kernel - Re: [PATCH 1/3] dt-bindings: st7571-i2c: Add Sitronix ST7571 panel bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z-6hAzDHm8zOOrrw@gmail.com>
Date: Thu, 3 Apr 2025 16:53:55 +0200
From: Marcus Folkesson <marcus.folkesson@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, dri-devel@...ts.freedesktop.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: st7571-i2c: Add Sitronix ST7571 panel
 bindings

On Thu, Apr 03, 2025 at 04:28:22PM +0200, Krzysztof Kozlowski wrote:
> On 03/04/2025 12:31, Marcus Folkesson wrote:
> >>> +    i2c {
> >>> +        #address-cells = <1>;
> >>> +        #size-cells = <0>;
> >>> +
> >>> +        display@3f {
> >>
> >> Look how this is called in other bindings... The binding and example are
> >> not following existing code. Why? Why doing something entirely
> >> different?
> > 
> > Sorry, I'm not sure what you mean here.
> You added code entirely different than existing code. Why doing
> something entirely different? Open any other panel and look how it is
> called.

This is still unclear to me.

I assume you are referring to the display@3f?
I can see many other panels use display@<address>, e.g.
elgin,jg10309-01.yaml
and 
sitronix,st7735r.yaml

Those are using address 0, but that is because they are SPI devices,
this is a I2C device and address 0 is not valid. 
There are plenty of examples of I2C devices using the real addresses in the
node name.

Or do you want me to call it panel@3f ?
I can go with that if it is preferred.

> 
> Best regards,
> Krzysztof

Best regards,
Marcus Folkesson

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)