linux-kernel - Re: [PATCH] irqchip/loongson-liointc: Support to set IRQ_TYPE_EDGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jz81uty3.ffs@tglx>
Date: Thu, 03 Apr 2025 17:48:52 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Huacai Chen <chenhuacai@...ngson.cn>
Cc: loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org, Xuefeng Li
 <lixuefeng@...ngson.cn>, Huacai Chen <chenhuacai@...il.com>, Jiaxun Yang
 <jiaxun.yang@...goat.com>, Huacai Chen <chenhuacai@...ngson.cn>,
 stable@...r.kernel.org, Yinbo Zhu <zhuyinbo@...ngson.cn>
Subject: Re: [PATCH] irqchip/loongson-liointc: Support to set
 IRQ_TYPE_EDGE_BOTH

On Wed, Apr 02 2025 at 17:25, Huacai Chen wrote:
> Some peripheral subsystems request IRQ_TYPE_EDGE_BOTH interrupt type and
> report request failures on LIOINTC. To avoid such failures we support to
> set IRQ_TYPE_EDGE_BOTH type on LIOINTC, by setting LIOINTC_REG_INTC_EDGE
> to true and keep LIOINTC_REG_INTC_POL as is.

That's broken because it will either trigger on the rising or the
falling edge depending on the setting of LIOINTC_REG_INTC_POL.

But it won't trigger on both. So no, you cannot claim that this fixes
anything.

Thanks,

        tglx