linux-kernel - Re: [PATCH 1/3] crypto: x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250403164335.GA1241@sol.localdomain>
Date: Thu, 3 Apr 2025 09:43:35 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Uros Bizjak <ubizjak@...il.com>
Cc: linux-crypto@...r.kernel.org, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 1/3] crypto: x86 - Remove CONFIG_AS_SHA1_NI

On Thu, Apr 03, 2025 at 11:44:39AM +0200, Uros Bizjak wrote:
> Current minimum required version of binutils is 2.25,
> which supports SHA-1 instruction mnemonics.
> 
> Remove check for assembler support of SHA-1 instructions
> and all relevant macros for conditional compilation.
> 
> No functional change intended.
> 
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> ---
>  arch/x86/Kconfig.assembler        |  5 -----
>  arch/x86/crypto/Makefile          |  3 +--
>  arch/x86/crypto/sha1_ssse3_glue.c | 10 ----------
>  3 files changed, 1 insertion(+), 17 deletions(-)

Reviewed-by: Eric Biggers <ebiggers@...nel.org>

- Eric