linux-kernel - Re: [PATCH v1] PCI/AER: Avoid power state transition during system suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-7Sty6Vg61BGUu0@black.fi.intel.com>
Date: Thu, 3 Apr 2025 21:25:59 +0300
From: Raag Jadav <raag.jadav@...el.com>
To: rafael@...nel.org, mahesh@...ux.ibm.com, oohall@...il.com,
	bhelgaas@...gle.com
Cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	ilpo.jarvinen@...ux.intel.com, lukas@...ner.de
Subject: Re: [PATCH v1] PCI/AER: Avoid power state transition during system
 suspend

On Thu, Apr 03, 2025 at 01:14:25PM +0530, Raag Jadav wrote:
> If an error is triggered while system suspend is in progress, any bus
> level power state transition will result in unpredictable error handling.
> Mark skip_bus_pm flag as true to avoid this.
> 
> Signed-off-by: Raag Jadav <raag.jadav@...el.com>
> ---
> 
> Ideally we'd want to defer recovery until system resume, but this is
> good enough to prevent device suspend.
> 
> More discussion at [1].
> [1] https://lore.kernel.org/r/Z-38rPeN_j7YGiEl@black.fi.intel.com

I just realized I messed up the link, please use [2] instead.
Apologies for the inconvenience.

[2] https://lore.kernel.org/all/CAJZ5v0g-aJXfVH+Uc=9eRPuW08t-6PwzdyMXsC6FZRKYJtY03Q@mail.gmail.com

>  drivers/pci/pcie/aer.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index 508474e17183..5acf4efc2df3 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -1108,6 +1108,12 @@ static void pci_aer_handle_error(struct pci_dev *dev, struct aer_err_info *info)
>  
>  static void handle_error_source(struct pci_dev *dev, struct aer_err_info *info)
>  {
> +	/*
> +	 * Avoid any power state transition if an error is triggered during
> +	 * system suspend.
> +	 */
> +	dev->skip_bus_pm = true;
> +
>  	cxl_rch_handle_error(dev, info);
>  	pci_aer_handle_error(dev, info);
>  	pci_dev_put(dev);
> -- 
> 2.34.1
>