linux-kernel - Re: [PATCH v3 1/4] kernel/resource: Provide mem region release for SOFT RESERVES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd9ef946-2d8e-4a43-ac62-dab09f97934a@amd.com>
Date: Thu, 3 Apr 2025 13:50:38 -0500
From: "Bowman, Terry" <terry.bowman@....com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: dave@...olabs.net, jonathan.cameron@...wei.com, dave.jiang@...el.com,
 alison.schofield@...el.com, vishal.l.verma@...el.com, ira.weiny@...el.com,
 dan.j.williams@...el.com, willy@...radead.org, jack@...e.cz,
 rafael@...nel.org, len.brown@...el.com, pavel@....cz, ming.li@...omail.com,
 nathan.fontenot@....com, Smita.KoralahalliChannabasappa@....com,
 huang.ying.caritas@...il.com, yaoxt.fnst@...itsu.com, peterz@...radead.org,
 gregkh@...uxfoundation.org, quic_jjohnson@...cinc.com,
 ilpo.jarvinen@...ux.intel.com, bhelgaas@...gle.com,
 mika.westerberg@...ux.intel.com, akpm@...ux-foundation.org,
 gourry@...rry.net, linux-cxl@...r.kernel.org, linux-kernel@...r.kernel.org,
 nvdimm@...ts.linux.dev, linux-fsdevel@...r.kernel.org,
 linux-pm@...r.kernel.org, rrichter@....com, benjamin.cheatham@....com,
 PradeepVineshReddy.Kodamati@....com, lizhijian@...itsu.com
Subject: Re: [PATCH v3 1/4] kernel/resource: Provide mem region release for
 SOFT RESERVES

Hi Andy,

Thanks for reviewing this. I'll make updates for all you pointed out below.

Regards,
Terry

On 4/3/2025 1:40 PM, Andy Shevchenko wrote:
> On Thu, Apr 03, 2025 at 01:33:12PM -0500, Terry Bowman wrote:
>> From: Nathan Fontenot <nathan.fontenot@....com>
>>
>> Add a release_Sam_region_adjustable() interface to allow for
>> removing SOFT RESERVE memory resources. This extracts out the code
>> to remove a mem region into a common __release_mem_region_adjustable()
>> routine, this routine takes additional parameters of an IORES
>> descriptor type to add checks for IORES_DESC_* and a flag to check
>> for IORESOURCE_BUSY to control it's behavior.
>>
>> The existing release_mem_region_adjustable() is a front end to the
>> common code and a new release_srmem_region_adjustable() is added to
>> release SOFT RESERVE resources.
> ...
>
>> +void release_mem_region_adjustable(resource_size_t start, resource_size_t size)
>> +{
>> +	return __release_mem_region_adjustable(start, size,
> You have still room on the previous line for the parameters.
>
>> +					       true, IORES_DESC_NONE);
> Return on void?! Interesting... What do you want to do here?
>
>> +}
>> +EXPORT_SYMBOL(release_mem_region_adjustable);
>> +#endif
>> +
>> +#ifdef CONFIG_CXL_REGION
>> +void release_srmem_region_adjustable(resource_size_t start,
>> +				     resource_size_t size)
> This can be put on a single line.
>
>> +{
>> +	return __release_mem_region_adjustable(start, size,
>> +					       false, IORES_DESC_SOFT_RESERVED);
> Same comments as per above function.
>
>> +}
>> +EXPORT_SYMBOL(release_srmem_region_adjustable);
>> +#endif