linux-kernel - Re: [PATCH] nfs: Add missing release on error in nfs_lock_and_join

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250403043559.GA22698@lst.de>
Date: Thu, 3 Apr 2025 06:35:59 +0200
From: Christoph Hellwig <hch@....de>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Christoph Hellwig <hch@....de>, Trond Myklebust <trondmy@...nel.org>,
	Anna Schumaker <anna@...nel.org>, Sagi Grimberg <sagi@...mberg.me>,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] nfs: Add missing release on error in
 nfs_lock_and_join_requests()

On Wed, Apr 02, 2025 at 02:02:40PM +0300, Dan Carpenter wrote:
> Call nfs_release_request() on this error path before returning.
> 
> Fixes: c3f2235782c3 ("nfs: fold nfs_folio_find_and_lock_request into nfs_lock_and_join_requests")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>