linux-kernel - Re: [PATCH 1/2] staging: media: Remove NULL test on an already tested value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcT5OBxo2jMTYK6Vw8MB+h+jBWT42GVtS27YTkq-JZoLA@mail.gmail.com>
Date: Thu, 3 Apr 2025 08:18:47 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Abraham Samuel Adekunle <abrahamadekunle50@...il.com>
Cc: outreachy@...ts.linux.dev, julia.lawall@...ia.fr, hdegoede@...hat.com, 
	mchehab@...nel.org, sakari.ailus@...ux.intel.com, andy@...nel.org, 
	gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: media: Remove NULL test on an already tested value

On Thu, Apr 3, 2025 at 2:30 AM Abraham Samuel Adekunle
<abrahamadekunle50@...il.com> wrote:
>
> When a value has been tested for NULL in an expression, a
> second NULL test on the same value in another expression
> is unnecessary when the value has not been assigned NULL.
>
> Remove unnecessary duplicate NULL tests on the same value that
> has previously been NULL tested.

>  drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 2 +-
>  drivers/staging/media/av7110/sp8870.c                     | 2 +-

Please, split this on per driver basis, as they have different
maintainers and trees to go through.

...

> --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> @@ -1292,7 +1292,7 @@ static int gmin_get_config_dsm_var(struct device *dev,
>          * if it founds something different than string, letting it
>          * to fall back to the old code.
>          */
> -       if (cur && cur->type != ACPI_TYPE_STRING) {
> +       if (cur->type != ACPI_TYPE_STRING) {
>                 dev_info(dev, "found non-string _DSM entry for '%s'\n", var);
>                 ACPI_FREE(obj);
>                 return -EINVAL;

This change is good.

...

> diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c
> index 0c813860f5b2..8c5fa5ed5340 100644
> --- a/drivers/staging/media/av7110/sp8870.c
> +++ b/drivers/staging/media/av7110/sp8870.c
> @@ -508,7 +508,7 @@ static int sp8870_set_frontend(struct dvb_frontend *fe)
>         }
>
>         if (debug) {
> -               if (valid) {
> +               {
>                         if (trials > 1) {
>                                 pr_info("%s(): firmware lockup!!!\n", __func__);
>                                 pr_info("%s(): recovered after %i trial(s))\n",  __func__, trials - 1);

But this is not fully done. Why do we need to keep {}? Just shift left
the code and remove those {} altogether.

-- 
With Best Regards,
Andy Shevchenko