linux-kernel - Re: [PATCH 2/5] iio: adc: ad7380: rename internal_ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ccf7767e4c447aa5febad9c6139c1e76dbfd19f6.camel@gmail.com>
Date: Thu, 03 Apr 2025 19:53:32 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: David Lechner <dlechner@...libre.com>, Jonathan Cameron
 <jic23@...nel.org>,  Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
 linux-iio@...r.kernel.org
Cc: Michael Hennerich <Michael.Hennerich@...log.com>, Nuno
 Sá
	 <nuno.sa@...log.com>, Jonathan Corbet <corbet@....net>, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-doc@...r.kernel.org
Subject: Re: [PATCH 2/5] iio: adc: ad7380: rename internal_ref_only

On Tue, 2025-04-01 at 17:50 -0500, David Lechner wrote:
> Rename adaq_internal_ref_only to internal_ref_only_adaq. There are non-
> ADAQ chips in the family that are also internal reference only, so the
> adaq_ prefix is misleading.
> 
> Signed-off-by: David Lechner <dlechner@...libre.com>
> ---

Reviewed-by: Nuno Sá <nuno.sa@...log.com>

>  drivers/iio/adc/ad7380.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7380.c b/drivers/iio/adc/ad7380.c
> index
> 4fcb49fdf56639784098f0147a9faef8dcb6b0f6..18ed07275be8e031e54f3595f70afe47514084cd
> 100644
> --- a/drivers/iio/adc/ad7380.c
> +++ b/drivers/iio/adc/ad7380.c
> @@ -119,7 +119,7 @@ struct ad7380_chip_info {
>  	const char * const *supplies;
>  	unsigned int num_supplies;
>  	bool external_ref_only;
> -	bool adaq_internal_ref_only;
> +	bool internal_ref_only;
>  	const char * const *vcm_supplies;
>  	unsigned int num_vcm_supplies;
>  	const unsigned long *available_scan_masks;
> @@ -806,7 +806,7 @@ static const struct ad7380_chip_info adaq4370_4_chip_info = {
>  	.num_simult_channels = 4,
>  	.supplies = adaq4380_supplies,
>  	.num_supplies = ARRAY_SIZE(adaq4380_supplies),
> -	.adaq_internal_ref_only = true,
> +	.internal_ref_only = true,
>  	.has_hardware_gain = true,
>  	.available_scan_masks = ad7380_4_channel_scan_masks,
>  	.timing_specs = &ad7380_4_timing,
> @@ -821,7 +821,7 @@ static const struct ad7380_chip_info adaq4380_4_chip_info = {
>  	.num_simult_channels = 4,
>  	.supplies = adaq4380_supplies,
>  	.num_supplies = ARRAY_SIZE(adaq4380_supplies),
> -	.adaq_internal_ref_only = true,
> +	.internal_ref_only = true,
>  	.has_hardware_gain = true,
>  	.available_scan_masks = ad7380_4_channel_scan_masks,
>  	.timing_specs = &ad7380_4_timing,
> @@ -836,7 +836,7 @@ static const struct ad7380_chip_info adaq4381_4_chip_info = {
>  	.num_simult_channels = 4,
>  	.supplies = adaq4380_supplies,
>  	.num_supplies = ARRAY_SIZE(adaq4380_supplies),
> -	.adaq_internal_ref_only = true,
> +	.internal_ref_only = true,
>  	.has_hardware_gain = true,
>  	.available_scan_masks = ad7380_4_channel_scan_masks,
>  	.timing_specs = &ad7380_4_timing,
> @@ -1847,7 +1847,7 @@ static int ad7380_probe(struct spi_device *spi)
>  				     "Failed to enable power supplies\n");
>  	fsleep(T_POWERUP_US);
>  
> -	if (st->chip_info->adaq_internal_ref_only) {
> +	if (st->chip_info->internal_ref_only) {
>  		/*
>  		 * ADAQ chips use fixed internal reference but still
>  		 * require a specific reference supply to power it.
>