linux-kernel - Re: [PATCH] sfc: Add error handling for devlink_info_serial_number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250403151735.69461ade@kernel.org>
Date: Thu, 3 Apr 2025 15:17:35 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: ecree.xilinx@...il.com, habetsm.xilinx@...il.com, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 netdev@...r.kernel.org, linux-net-drivers@....com,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] sfc: Add error handling for
 devlink_info_serial_number_put()

On Tue,  1 Apr 2025 21:05:57 +0800 Wentao Liang wrote:
>  	if (!rc) {
>  		snprintf(sn, EFX_MAX_SERIALNUM_LEN, "%pm", mac_address);
> -		devlink_info_serial_number_put(req, sn);
> +		err = devlink_info_serial_number_put(req, sn);
> +		if (err)
> +			return err;

Why are you introducing another variable? You can do this:

	if (rc)
		return rc;
	snprintf...
	return devlink_info..
-- 
pw-bot: cr