linux-kernel - Re: [PATCH v2 3/3] staging: rtl8723bs: Prevent duplicate NULL tests on a value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADYq+fY-y1BqnzK7fCvjPhLfvpTgMeiK5_XCoF_BZqiYyX_1bw@mail.gmail.com>
Date: Fri, 4 Apr 2025 00:34:40 +0100
From: Samuel Abraham <abrahamadekunle50@...il.com>
To: Andy Shevchenko <andy@...nel.org>
Cc: outreachy@...ts.linux.dev, julia.lawall@...ia.fr, 
	gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, hdegoede@...hat.com, mchehab@...nel.org, 
	sakari.ailus@...ux.intel.com
Subject: Re: [PATCH v2 3/3] staging: rtl8723bs: Prevent duplicate NULL tests
 on a value

On Thu, Apr 3, 2025 at 2:40 PM Andy Shevchenko <andy@...nel.org> wrote:
>
> On Thu, Apr 03, 2025 at 02:26:43PM +0100, Abraham Samuel Adekunle wrote:
> > When a value has been tested for NULL in an expression, a
> > second NULL test on the same value in another expression
> > is unnecessary when the value has not been assigned NULL.
> >
> > Remove unnecessary duplicate NULL tests on the same value that
> > has previously been NULL tested.
> >
> > Found by Coccinelle
>
> Missing period.

Noted.
...
> > +                                     psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq+1)&0xfff;
>
> While at it, make this more readable:
>
>                                         psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =
>                                                 (tx_seq + 1) & 0xfff;
>
>
> > +                                     pattrib->ampdu_en = true;/* AGG EN */
> > +                             } else {
>
> > +                                     psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum+1)&0xfff;
>
> Ditto.
>
> Also consider to use module operator as it shows the exact amount of the
> records we support in the circular buffer.
>
>                                         psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =
>                                                 (pattrib->seqnum + 1) % 4096;
>
> Since it's power-of-two denominator, it will be optimised by the compiler to
> the same code as it's now.
>
> > +                                     pattrib->ampdu_en = true;/* AGG EN */
> >                               }
>
>
Thank you very much for the review
I will send an updated Patchset

Adekunle