linux-kernel - Re: [PATCH] perf tools: Fix incorrect --user-regs comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <762e01c1-c78c-4bd7-aec4-4cc56563da20@linux.intel.com>
Date: Thu, 3 Apr 2025 08:42:16 +0800
From: "Mi, Dapeng" <dapeng1.mi@...ux.intel.com>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Kan Liang <kan.liang@...ux.intel.com>, linux-perf-users@...r.kernel.org,
 linux-kernel@...r.kernel.org, Dapeng Mi <dapeng1.mi@...el.com>
Subject: Re: [PATCH] perf tools: Fix incorrect --user-regs comments


On 4/3/2025 12:55 AM, Ian Rogers wrote:
> On Tue, Apr 1, 2025 at 8:58 PM Dapeng Mi <dapeng1.mi@...ux.intel.com> wrote:
>> The comment of "--user-regs" option is not correct, fix it.
>>
>> "on interrupt," -> "on user space,"
> nit: I think "in user space" is more grammatical.

Sure.


>
>> Fixes: 84c417422798 ("perf record: Support direct --user-regs arguments")
>> Signed-off-by: Dapeng Mi <dapeng1.mi@...ux.intel.com>
>> ---
>>  tools/perf/builtin-record.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
>> index ba20bf7c011d..f21b133691d7 100644
>> --- a/tools/perf/builtin-record.c
>> +++ b/tools/perf/builtin-record.c
>> @@ -3480,7 +3480,7 @@ static struct option __record_options[] = {
>>                     "sample selected machine registers on interrupt,"
>>                     " use '-I?' to list register names", parse_intr_regs),
>>         OPT_CALLBACK_OPTARG(0, "user-regs", &record.opts.sample_user_regs, NULL, "any register",
>> -                   "sample selected machine registers on interrupt,"
>> +                   "sample selected machine registers on user space,"
> nit: "sample selected machine registers in user space"
>
> Reviewed-by: Ian Rogers <irogers@...gle.com>

Sure. Thanks for reviewing.


>
> Thanks,
> Ian
>
>>                     " use '--user-regs=?' to list register names", parse_user_regs),
>>         OPT_BOOLEAN(0, "running-time", &record.opts.running_time,
>>                     "Record running/enabled time of read (:S) events"),
>>
>> base-commit: 35d13f841a3d8159ef20d5e32a9ed3faa27875bc
>> --
>> 2.40.1
>>