linux-kernel - RE: [PATCH v3 0/3] Add driver for AD3530R and AD3531R DACs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH0PR03MB714139DBEC9D4035F7CD243DF9AE2@PH0PR03MB7141.namprd03.prod.outlook.com>
Date: Thu, 3 Apr 2025 06:58:28 +0000
From: "Paller, Kim Seer" <KimSeer.Paller@...log.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        "linux-iio@...r.kernel.org"
	<linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>
Subject: RE: [PATCH v3 0/3] Add driver for AD3530R and AD3531R DACs



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Thursday, April 3, 2025 2:44 PM
> To: Paller, Kim Seer <KimSeer.Paller@...log.com>
> Cc: Jonathan Cameron <jic23@...nel.org>; Lars-Peter Clausen
> <lars@...afoo.de>; Hennerich, Michael <Michael.Hennerich@...log.com>;
> Rob Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>;
> Conor Dooley <conor+dt@...nel.org>; linux-iio@...r.kernel.org; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org
> Subject: Re: [PATCH v3 0/3] Add driver for AD3530R and AD3531R DACs
> 
> [External]
> 
> On Thu, Apr 03, 2025 at 01:33:54PM +0800, Kim Seer Paller wrote:
> > The AD3530/AD3530R (8-channel) and AD3531/AD3531R (4-channel) are
> > low-power, 16-bit, buffered voltage output DACs with software-
> > programmable gain controls, providing full-scale output spans of 2.5V
> > or 5V for reference voltages of 2.5V. These devices operate from a
> > single 2.7V to 5.5V supply and are guaranteed monotonic by design. The "R"
> > variants include a 2.5V, 5ppm/°C internal reference, which is disabled
> > by default.
> >
> > The AD3531R/AD3531 is not yet released, so the only available
> > datasheet for now is the AD3530R/AD3530. The only differences between
> > the two is the number of channels, and register addresses of some registers.
> >
> > Signed-off-by: Kim Seer Paller <kimseer.paller@...log.com>
> > ---
> > Changes in v3:
> > - Drop ABI docs.
> >
> > Bindings:
> > - Drop reviewer's tag.
> 
> Why? Explain why you are dropping.

I introduce modifications that might require re-review of the updated implementation
(e.g, adding io-channels property, switching to unevaluatedProperties: false, and adding
non-r variants to the compatible list). Is the tag still applicable?

> 
> Best regards,
> Krzysztof