linux-kernel - Re: [PATCH net 3/3] net: hns3: store rx VLAN tag offload state for VF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88dcf938-f43d-44f8-a943-ab84aa2edf2b@huawei.com>
Date: Thu, 3 Apr 2025 09:21:20 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Simon Horman <horms@...nel.org>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <andrew+netdev@...n.ch>,
	<shenjian15@...wei.com>, <wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>,
	<chenhao418@...wei.com>, <jonathan.cameron@...wei.com>,
	<shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net 3/3] net: hns3: store rx VLAN tag offload state for VF


on 2025/4/2 22:01, Simon Horman wrote:
> On Wed, Apr 02, 2025 at 08:10:01PM +0800, Jijie Shao wrote:
>> From: Jian Shen <shenjian15@...wei.com>
>>
>> The VF driver missed to store the rx VLAN tag strip state when
>> user change the rx VLAN tag offload state. And it will default
>> to enable the rx vlan tag strip when re-init VF device after
>> reset. So if user disable rx VLAN tag offload, and trig reset,
>> then the HW will still strip the VLAN tag from packet nad fill
>> into RX BD, but the VF driver will ignore it for rx VLAN tag
>> offload disabled. It may cause the rx VLAN tag dropped.
>>
>> Fixes: b2641e2ad456 ("net: hns3: Add support of hardware rx-vlan-offload to HNS3 VF driver")
>> Signed-off-by: Jian Shen <shenjian15@...wei.com>
>> Signed-off-by: Jijie Shao <shaojijie@...wei.com>
> Overall this looks good to me.
>
> Reviewed-by: Simon Horman <horms@...nel.org>
>
> ...
>
>> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h
>> index cccef3228461..1e452b14b04e 100644
>> --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h
>> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h
>> @@ -252,7 +252,8 @@ struct hclgevf_dev {
>>   	u16 *vector_status;
>>   	int *vector_irq;
>>   
>> -	bool gro_en;
>> +	u32 gro_en :1;
>> +	u32 rxvtag_strip_en :1;
> FWIIW, as there is space I would have used two bools here.

ok, I will change to bool in v2

Thanks,
Jijie Shao

>
>>   
>>   	unsigned long vlan_del_fail_bmap[BITS_TO_LONGS(VLAN_N_VID)];
>>   
>> -- 
>> 2.33.0
>>