linux-kernel - Re: [PATCH v4 7/9] arm64: dts: freescale: Add the BOE av101hdt-a10 variant of the Moduline Displayy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PA4PR04MB7630AC77144FD2D9995D70D1C5AE2@PA4PR04MB7630.eurprd04.prod.outlook.com>
Date: Thu, 3 Apr 2025 07:44:24 +0000
From: Maud Spierings | GOcontroll <maudspierings@...ontroll.com>
To: Frank Li <Frank.li@....com>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha
 Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
	<kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 7/9] arm64: dts: freescale: Add the BOE av101hdt-a10
 variant of the Moduline Displayy

On 4/2/25 21:35, Frank Li wrote:
> On Wed, Apr 02, 2025 at 09:07:10AM +0200, Maud Spierings via B4 Relay wrote:
>> From: Maud Spierings <maudspierings@...ontroll.com>
>>
>> Add the BOE av101hdt-a10 variant of the Moduline Display, this variant
>> comes with a 10.1 1280x720 display with a touchscreen (not working in
>> mainline).
>>
>> Signed-off-by: Maud Spierings <maudspierings@...ontroll.com>
>>
>> ---
>> Currently the backlight driver is not available, this will be upstreamed
>> in a future patch series. It is a Maxim max25014atg.
>>
>> The touchscreen has a Cypress CYAT81658-64AS48 controller which as far as
>> I know is not supported upstream, the driver we currently use for this is
>> a mess and I doubt we will be able to get it in an upstreamable state.
>> ---
>>   ...x8p-ml81-moduline-display-106-av101hdt-a10.dtso | 102 +++++++++++++++++++++
>>   1 file changed, 102 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106-av101hdt-a10.dtso b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106-av101hdt-a10.dtso
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..2855d7090988380ca0d4df8459cd1a67049f1080
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106-av101hdt-a10.dtso
>> @@ -0,0 +1,102 @@
>> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
>> +/*
>> + * Copyright 2025 GOcontroll B.V.
>> + * Author: Maud Spierings <maudspierings@...ontroll.com>
>> + */
>> +
>> +#include <dt-bindings/clock/imx8mp-clock.h>
>> +#include <dt-bindings/gpio/gpio.h>
>> +
>> +#include "imx8mp-pinfunc.h"
>> +
>> +/dts-v1/;
>> +/plugin/;
>> +
>> +/ {
>> +	model = "GOcontroll Moduline Display with BOE av101hdt-a10 display";
>> +
>> +	panel {
>> +		compatible = "boe,av101hdt-a10";
>> +		enable-gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>;
>> +		pinctrl-0 = <&pinctrl_panel>;
>> +		pinctrl-names = "default";
>> +		power-supply = <&reg_3v3_per>;
>> +		reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
>> +
>> +		port {
>> +			panel_lvds_in: endpoint {
>> +				remote-endpoint = <&ldb_lvds_ch0>;
>> +			};
>> +		};
>> +	};
>> +
>> +	reg_vbus: regulator-vbus {
>> +		compatible = "regulator-fixed";
>> +		power-supply = <&reg_6v4>;
>> +		regulator-always-on;
>> +		regulator-max-microvolt = <5000000>;
>> +		regulator-min-microvolt = <5000000>;
>> +		regulator-name = "usb-c-vbus";
>> +	};
>> +};
>> +
>> +&iomuxc {
>> +	pinctrl_panel: panelgrp {
>> +		fsl,pins = <
>> +			MX8MP_IOMUXC_GPIO1_IO07__GPIO1_IO07
>> +			MX8MP_DSE_X1
>> +			MX8MP_IOMUXC_GPIO1_IO09__GPIO1_IO09
>> +			MX8MP_DSE_X1
>> +		>;
>> +	};
>> +};
>> +
>> +&lcdif2 {
>> +	status = "okay";
>> +};
>> +
>> +&lvds_bridge {
>> +	assigned-clocks = <&clk IMX8MP_CLK_MEDIA_LDB>, <&clk IMX8MP_VIDEO_PLL1>;
>> +	/* IMX8MP_VIDEO_PLL1 = IMX8MP_CLK_MEDIA_DISP2_PIX * 2 * 7 */
>> +	assigned-clock-rates = <0>, <1054620000>;
>> +	status = "okay";
>> +
>> +	ports {
>> +		port@1 {
>> +			ldb_lvds_ch0: endpoint {
>> +				remote-endpoint = <&panel_lvds_in>;
>> +			};
>> +		};
>> +	};
>> +};
>> +
>> +&usb3_1 {
>> +	status = "okay";
>> +};
>> +
>> +&usb3_phy1 {
>> +	status = "okay";
>> +};
>> +
>> +&usb_dwc3_1 {
>> +	dr_mode = "host";
>> +
>> +	connector {
>> +		compatible = "usb-c-connector";
>> +		data-role = "host";
>> +		pd-disable;
>> +		vbus-supply = <&reg_vbus>;
>> +
>> +		port {
>> +			high_speed_ep: endpoint {
>> +				remote-endpoint = <&usb1_hs_ep>;
>> +			};
>> +		};
>> +	};
>> +
>> +	port {
>> +		usb1_hs_ep: endpoint {
>> +			remote-endpoint = <&high_speed_ep>;
>> +		};
>> +	};
>> +};
> 
> why need enable usb3 in overlay file, I suppose it should be already enabled
> at base dtb file.

It seems useless to me to enable the usb when the av123z7m-n17 board is
attached as it doesn't use it, but I guess it would make sense to put
the usb/phy in the mainboard and keep only the connector/dwc in this
overlay.

> Frank
>>
>> --
>> 2.49.0
>>
>>
-- 
Met vriendelijke groeten/with kind regards,
Maud Spierings