linux-kernel - Re: [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded of_gpio_n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7fd0bd4-4fc8-43f0-b980-b49472e76445@ideasonboard.com>
Date: Thu, 3 Apr 2025 11:07:40 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded
 of_gpio_n_cells assignment

Hi,

On 31/03/2025 10:02, Andy Shevchenko wrote:
> The default for of_gpio_n_cells is 2, no need to assign the same
> in the user.

Where is this documented? I'm also having trouble finding the 
implementation.

  Tomi

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/media/i2c/ds90ub913.c | 1 -
>   drivers/media/i2c/ds90ub953.c | 1 -
>   2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c
> index fd2d2d5272bf..834df8d508e6 100644
> --- a/drivers/media/i2c/ds90ub913.c
> +++ b/drivers/media/i2c/ds90ub913.c
> @@ -216,7 +216,6 @@ static int ub913_gpiochip_probe(struct ub913_data *priv)
>   	gc->direction_output = ub913_gpio_direction_out;
>   	gc->set = ub913_gpio_set;
>   	gc->of_xlate = ub913_gpio_of_xlate;
> -	gc->of_gpio_n_cells = 2;
>   
>   	ret = gpiochip_add_data(gc, priv);
>   	if (ret) {
> diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
> index 46569381b332..1cd5ac7157e4 100644
> --- a/drivers/media/i2c/ds90ub953.c
> +++ b/drivers/media/i2c/ds90ub953.c
> @@ -420,7 +420,6 @@ static int ub953_gpiochip_probe(struct ub953_data *priv)
>   	gc->get = ub953_gpio_get;
>   	gc->set = ub953_gpio_set;
>   	gc->of_xlate = ub953_gpio_of_xlate;
> -	gc->of_gpio_n_cells = 2;
>   
>   	ret = gpiochip_add_data(gc, priv);
>   	if (ret) {