linux-kernel - Re: [PATCH v1 1/1] media: raspberrypi: rp1-cfe: Remove (explicitly) unused header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <66918495-e6fd-4565-a344-edf786b5aba0@ideasonboard.com>
Date: Thu, 3 Apr 2025 11:10:24 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Cc: Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH v1 1/1] media: raspberrypi: rp1-cfe: Remove (explicitly)
 unused header

Hi,

On 31/03/2025 10:21, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
> 
> Note, that fwnode API for drivers is provided in property.h
> which is included here.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> index 69a5f23e7954..fcadb2143c88 100644
> --- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> +++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> @@ -12,7 +12,6 @@
>   #include <linux/device.h>
>   #include <linux/dma-mapping.h>
>   #include <linux/err.h>
> -#include <linux/fwnode.h>
>   #include <linux/init.h>
>   #include <linux/interrupt.h>
>   #include <linux/io.h>

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>

  Tomi