linux-kernel - Re: [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove (explicitly) unused header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e966c2df-330b-4897-a7e4-4e711bb809de@ideasonboard.com>
Date: Thu, 3 Apr 2025 11:10:43 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove (explicitly) unused
 header

Hi,

On 31/03/2025 10:25, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
> 
> Note, that fwnode API for drivers is provided in property.h
> which is included here.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/media/i2c/ds90ub913.c | 1 -
>   drivers/media/i2c/ds90ub953.c | 1 -
>   2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c
> index 834df8d508e6..352b3d26f376 100644
> --- a/drivers/media/i2c/ds90ub913.c
> +++ b/drivers/media/i2c/ds90ub913.c
> @@ -12,7 +12,6 @@
>   #include <linux/clk-provider.h>
>   #include <linux/clk.h>
>   #include <linux/delay.h>
> -#include <linux/fwnode.h>
>   #include <linux/gpio/driver.h>
>   #include <linux/i2c-atr.h>
>   #include <linux/i2c.h>
> diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
> index 1cd5ac7157e4..dc50517fd228 100644
> --- a/drivers/media/i2c/ds90ub953.c
> +++ b/drivers/media/i2c/ds90ub953.c
> @@ -11,7 +11,6 @@
>   #include <linux/clk-provider.h>
>   #include <linux/clk.h>
>   #include <linux/delay.h>
> -#include <linux/fwnode.h>
>   #include <linux/gpio/driver.h>
>   #include <linux/i2c-atr.h>
>   #include <linux/i2c.h>

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>

  Tomi