linux-kernel - Re: [PATCH v1 1/1] i2c: atr: Remove (explicitly) unused header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a7fe50f-84c1-475f-b72c-64d3f672a28a@ideasonboard.com>
Date: Thu, 3 Apr 2025 11:11:12 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Peter Zijlstra <peterz@...radead.org>, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Luca Ceresoli <luca.ceresoli@...tlin.com>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>
Subject: Re: [PATCH v1 1/1] i2c: atr: Remove (explicitly) unused header

Hi,

On 31/03/2025 10:16, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
> 
> Note, that fwnode API for drivers is provided in property.h
> which is included here.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/i2c/i2c-atr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/i2c-atr.c b/drivers/i2c/i2c-atr.c
> index 8fe9ddff8e96..783fb8df2ebe 100644
> --- a/drivers/i2c/i2c-atr.c
> +++ b/drivers/i2c/i2c-atr.c
> @@ -8,12 +8,12 @@
>    * Originally based on i2c-mux.c
>    */
>   
> -#include <linux/fwnode.h>
>   #include <linux/i2c-atr.h>
>   #include <linux/i2c.h>
>   #include <linux/kernel.h>
>   #include <linux/module.h>
>   #include <linux/mutex.h>
> +#include <linux/property.h>
>   #include <linux/slab.h>
>   #include <linux/spinlock.h>
>   

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>

  Tomi