linux-kernel - Re: [RFC PATCH 1/3] firmware: arm_scmi: Ensure that the message-id supports fastchannel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-5Dji5dbDsKXZE_@hovoldconsulting.com>
Date: Thu, 3 Apr 2025 10:15:10 +0200
From: Johan Hovold <johan@...nel.org>
To: Cristian Marussi <cristian.marussi@....com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	arm-scmi@...r.kernel.org, sudeep.holla@....com,
	james.quinlan@...adcom.com, f.fainelli@...il.com,
	vincent.guittot@...aro.org, peng.fan@....nxp.com,
	michal.simek@....com, quic_sibis@...cinc.com,
	dan.carpenter@...aro.org, maz@...nel.org, stable@...r.kernel.org,
	Johan Hovold <johan+linaro@...nel.org>
Subject: Re: [RFC PATCH 1/3] firmware: arm_scmi: Ensure that the message-id
 supports fastchannel

On Tue, Apr 01, 2025 at 01:25:43PM +0100, Cristian Marussi wrote:
> From: Sibi Sankar <quic_sibis@...cinc.com>
> 
> Currently the perf and powercap protocol relies on the protocol domain
> attributes, which just ensures that one fastchannel per domain, before
> instantiating fastchannels for all possible message-ids. Fix this by
> ensuring that each message-id supports fastchannel before initialization.
> 
> Logs:
> scmi: Failed to get FC for protocol 13 [MSG_ID:6 / RES_ID:0] - ret:-95. Using regular messaging.
> scmi: Failed to get FC for protocol 13 [MSG_ID:6 / RES_ID:1] - ret:-95. Using regular messaging.
> scmi: Failed to get FC for protocol 13 [MSG_ID:6 / RES_ID:2] - ret:-95. Using regular messaging.
> 
> CC: stable@...r.kernel.org
> Reported-by: Johan Hovold <johan+linaro@...nel.org>
> Closes: https://lore.kernel.org/lkml/ZoQjAWse2YxwyRJv@hovoldconsulting.com/
> Fixes: 6f9ea4dabd2d ("firmware: arm_scmi: Generalize the fast channel support")
> Signed-off-by: Sibi Sankar <quic_sibis@...cinc.com>
> [Cristian: Modified the condition checked to establish support or not]
> Signed-off-by: Cristian Marussi <cristian.marussi@....com>
> ---
> Since PROTOCOL_MESSAGE_ATTRIBUTES, used to check if message_id is supported,
> is a mandatory command, it cannot fail so we must bail-out NOT only if FC was
> not supported for that command but also if the query fails as a whole; so the
> condition checked for bailing out is modified to:
> 
> 	if (ret || !MSG_SUPPORTS_FASTCHANNEL(attributes)) {
> 
> Removed also Tested-by and Reviewed-by tags since I modified the logic.

This still works as intended:

Reviewed-by: Johan Hovold <johan+linaro@...nel.org>
Tested-by: Johan Hovold <johan+linaro@...nel.org>